office/evince
office/evince
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/evince synced 2024-06-30 22:54:23 +00:00
Code Issues Projects Releases Wiki Activity

Use G_SOURCE_CONTINUE and G_SOURCE_REMOVE when appropriate

Browse Source 
Instead of directly TRUE and FALSE, to improve readability. These are
used in GSourceFunc functions, and represent no change in behavior!
This commit is contained in:
Pablo Correa Gómez 2023-05-02 00:47:06 +02:00 committed by Nelson Ben
parent 130b8fb7f3
commit 19babb9114
10 changed files with 42 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libview/ev-job-scheduler.c
View File

@ -194,7 +194,7 @@ ev_job_idle (EvJob *job)
ev_debug_message (DEBUG_JOBS, "%s", EV_GET_TYPE_NAME (job));
if (g_cancellable_is_cancelled (job->cancellable))
return FALSE;
return G_SOURCE_REMOVE;
return ev_job_run (job);
}

2
libview/ev-jobs.c
View File

@ -178,7 +178,7 @@ emit_finished (EvJob *job)
g_signal_emit (job, job_signals[FINISHED], 0);
}
return FALSE;
return G_SOURCE_REMOVE;
}
static void

12
libview/ev-print-operation.c
View File

@ -946,7 +946,7 @@ export_print_page (EvPrintOperationExport *export)
EvPrintOperation *op = EV_PRINT_OPERATION (export);
if (!export->temp_file)
return FALSE; /* cancelled */
return G_SOURCE_REMOVE; /* cancelled */
export->total++;
export->collated++;
@ -967,7 +967,7 @@ export_print_page (EvPrintOperationExport *export)
update_progress (export);
export_print_done (export);
return FALSE;
return G_SOURCE_REMOVE;
}
}
@ -992,7 +992,7 @@ export_print_page (EvPrintOperationExport *export)
update_progress (export);
export_print_done (export);
return FALSE;
return G_SOURCE_REMOVE;
}
}
@ -1026,7 +1026,7 @@ export_print_page (EvPrintOperationExport *export)
update_progress (export);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -2462,11 +2462,11 @@ static gboolean
draw_page_finish_idle (EvPrintOperationPrint *print)
{
if (ev_job_scheduler_get_running_thread_job () == print->job_print)
return TRUE;
return G_SOURCE_CONTINUE;
gtk_print_operation_draw_page_finish (print->op);
return FALSE;
return G_SOURCE_REMOVE;
}
static void

4
libview/ev-timeline.c
View File

@ -165,13 +165,13 @@ ev_timeline_run_frame (EvTimeline *timeline)
}
g_signal_emit (timeline, signals [FINISHED], 0);
return FALSE;
return G_SOURCE_REMOVE;
} else {
ev_timeline_rewind (timeline);
}
}
return TRUE;
return G_SOURCE_CONTINUE;
}
static void

6
libview/ev-view-presentation.c
View File

@ -222,7 +222,7 @@ transition_next_page (EvViewPresentation *pview)
pview->trans_timeout_id = 0;
ev_view_presentation_next_page (pview);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -925,7 +925,7 @@ hide_cursor_timeout_cb (EvViewPresentation *pview)
ev_view_presentation_set_cursor (pview, EV_VIEW_CURSOR_HIDDEN);
pview->hide_cursor_timeout_id = 0;
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -1275,7 +1275,7 @@ init_presentation (GtkWidget *widget)
ev_view_presentation_update_current_page (pview, pview->current_page);
ev_view_presentation_hide_cursor_timeout_start (pview);
return FALSE;
return G_SOURCE_REMOVE;
}
static void

26
libview/ev-view.c
View File

@ -2513,7 +2513,7 @@ ev_view_forms_remove_widgets (EvView *view)
{
ev_view_remove_all_form_fields (view);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -2853,7 +2853,7 @@ ev_view_form_field_choice_popup_shown_real (PopupShownData *data)
g_object_unref (data->field);
g_free (data);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -4143,7 +4143,7 @@ blink_cb (EvView *view)
show_cursor (view);
view->cursor_blink_timeout_id = 0;
return FALSE;
return G_SOURCE_REMOVE;
}
blink_time = get_cursor_blink_time (view);
@ -4158,7 +4158,7 @@ blink_cb (EvView *view)
view->cursor_blink_timeout_id = gdk_threads_add_timeout (blink_time / CURSOR_DIVIDER, (GSourceFunc)blink_cb, view);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -5319,7 +5319,7 @@ link_preview_delayed_show (EvView *view)
gtk_widget_show (popover);
view->link_preview.delay_timeout_id = 0;
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -5883,7 +5883,7 @@ selection_update_idle_cb (EvView *view)
&view->selection_info.start,
&view->motion);
view->selection_update_id = 0;
return FALSE;
return G_SOURCE_REMOVE;
}
static gboolean
@ -5922,7 +5922,7 @@ selection_scroll_timeout_cb (EvView *view)
gtk_adjustment_get_upper (view->hadjustment) -
gtk_adjustment_get_page_size (view->hadjustment)));
return TRUE;
return G_SOURCE_CONTINUE;
}
static gboolean
@ -5930,7 +5930,7 @@ ev_view_drag_update_momentum (EvView *view)
{
int i;
if (!view->drag_info.in_drag)
return FALSE;
return G_SOURCE_REMOVE;
for (i = DRAG_HISTORY - 1; i > 0; i--) {
view->drag_info.buffer[i].x = view->drag_info.buffer[i-1].x;
@ -5944,7 +5944,7 @@ ev_view_drag_update_momentum (EvView *view)
view->drag_info.momentum.x = (view->drag_info.buffer[DRAG_HISTORY - 1].x - view->drag_info.buffer[0].x);
view->drag_info.momentum.y = (view->drag_info.buffer[DRAG_HISTORY - 1].y - view->drag_info.buffer[0].y);
return TRUE;
return G_SOURCE_CONTINUE;
}
static gboolean
@ -5993,9 +5993,9 @@ ev_view_scroll_drag_release (EvView *view)
if (((view->drag_info.momentum.x < 1) && (view->drag_info.momentum.x > -1)) &&
((view->drag_info.momentum.y < 1) && (view->drag_info.momentum.y > -1)))
return FALSE;
return G_SOURCE_REMOVE;
else
return TRUE;
return G_SOURCE_CONTINUE;
}
static gboolean
@ -7235,7 +7235,7 @@ ev_view_autoscroll_cb (EvView *view)
* set to false but the timeout will continue; stop the timeout: */
if (!view->scroll_info.autoscrolling) {
view->scroll_info.timeout_id = 0;
return FALSE;
return G_SOURCE_REMOVE;
}
/* Replace 100 with your speed of choice: The lower the faster.
@ -7254,7 +7254,7 @@ ev_view_autoscroll_cb (EvView *view)
gtk_adjustment_get_page_size (view->vadjustment));
gtk_adjustment_set_value (view->vadjustment, value);
return TRUE;
return G_SOURCE_CONTINUE;
}

2
shell/ev-file-monitor.c
View File

@ -99,7 +99,7 @@ timeout_cb (EvFileMonitor *ev_monitor)
g_signal_emit (ev_monitor, signals[CHANGED], 0);
priv->timeout_id = 0;
return FALSE;
return G_SOURCE_REMOVE;
}
static void

4
shell/ev-find-sidebar.c
View File

@ -461,7 +461,7 @@ process_matches_idle (EvFindSidebar *sidebar)
if (!ev_job_find_has_results (priv->job)) {
if (ev_job_is_finished (EV_JOB (priv->job)))
g_clear_object (&priv->job);
return FALSE;
return G_SOURCE_REMOVE;
}
document = EV_JOB (priv->job)->document;
@ -556,7 +556,7 @@ process_matches_idle (EvFindSidebar *sidebar)
if (ev_job_is_finished (EV_JOB (priv->job)) && priv->current_page == priv->job->start_page)
ev_find_sidebar_highlight_first_match_of_page (sidebar, priv->first_match_page);
return FALSE;
return G_SOURCE_REMOVE;
}
static void

2
shell/ev-sidebar-thumbnails.c
View File

@ -836,7 +836,7 @@ static gboolean
refresh (EvSidebarThumbnails *sidebar_thumbnails)
{
adjustment_changed_cb (sidebar_thumbnails);
return FALSE;
return G_SOURCE_REMOVE;
}
static void

24
shell/ev-window.c
View File

@ -844,7 +844,7 @@ show_loading_message_cb (EvWindow *window)
priv->loading_message_timeout = 0;
gtk_widget_show (priv->loading_message);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -1717,7 +1717,7 @@ ev_window_setup_document (EvWindow *ev_window)
else if (!gtk_search_bar_get_search_mode (GTK_SEARCH_BAR (priv->search_bar)))
gtk_widget_grab_focus (priv->view);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -2134,10 +2134,10 @@ show_loading_progress (EvWindow *ev_window)
EvWindowPrivate *priv = GET_PRIVATE (ev_window);
GtkWidget *area;
gchar *text;
gchar *display_name;
gchar *display_name;
if (priv->message_area)
return FALSE;
return G_SOURCE_REMOVE;
text = g_uri_unescape_string (priv->uri, NULL);
display_name = g_markup_escape_text (text, -1);
@ -2159,7 +2159,7 @@ show_loading_progress (EvWindow *ev_window)
g_free (text);
g_free (display_name);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -2604,7 +2604,7 @@ show_reloading_progress (EvWindow *ev_window)
gchar *text;
if (priv->message_area)
return FALSE;
return G_SOURCE_REMOVE;
text = g_strdup_printf (_("Reloading document from %s"),
priv->uri);
@ -2620,7 +2620,7 @@ show_reloading_progress (EvWindow *ev_window)
ev_window_set_message_area (ev_window, area);
g_free (text);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -2956,7 +2956,7 @@ show_saving_progress (GFile *dst)
priv->progress_idle = 0;
if (priv->message_area)
return FALSE;
return G_SOURCE_REMOVE;
save_type = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (dst), "save-type"));
uri = g_file_get_uri (dst);
@ -2986,7 +2986,7 @@ show_saving_progress (GFile *dst)
ev_window_set_message_area (ev_window, area);
g_free (text);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -3113,7 +3113,7 @@ destroy_window (GtkWidget *window)
{
gtk_widget_destroy (window);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -4535,7 +4535,7 @@ static gboolean
find_next_idle_cb (EvWindow *ev_window)
{
ev_window_find_next (ev_window);
return FALSE;
return G_SOURCE_REMOVE;
}
static void
@ -4564,7 +4564,7 @@ static gboolean
find_previous_idle_cb (EvWindow *ev_window)
{
ev_window_find_previous (ev_window);
return FALSE;
return G_SOURCE_REMOVE;
}
static void