From af0371fb7b887a2f5e09dcb6e42382393b07dc26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joris=20Pelgr=C3=B6m?= Date: Tue, 30 Aug 2022 02:26:39 +0200 Subject: [PATCH] Fix adding media player widget from settings (#2813) - Adding a media player widget from settings didn't work because the list used to check that entities have been selected isn't updated immediately, but only on load or in a callback after pinning the widget. To work around this, manually check it before pinning the widget. --- .../MediaPlayerControlsWidgetConfigureActivity.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/io/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidgetConfigureActivity.kt b/app/src/main/java/io/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidgetConfigureActivity.kt index 4dfe2655c..0973d3794 100644 --- a/app/src/main/java/io/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidgetConfigureActivity.kt +++ b/app/src/main/java/io/homeassistant/companion/android/widgets/media_player_controls/MediaPlayerControlsWidgetConfigureActivity.kt @@ -66,7 +66,10 @@ class MediaPlayerControlsWidgetConfigureActivity : BaseWidgetConfigureActivity() binding.addButton.setOnClickListener { if (requestLauncherSetup) { - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && selectedEntities.size > 0) { + if ( + Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && + binding.widgetTextConfigEntityId.text.split(",").any { entities[it.trim()] != null } + ) { getSystemService()?.requestPinAppWidget( ComponentName(this, MediaPlayerControlsWidget::class.java), null,