mobile/home-assistant-android
mobile/home-assistant-android
1
0
Fork 0
mirror of https://github.com/home-assistant/android synced 2024-07-22 10:54:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't crash when system is unable to handle download intent (#3108)

Browse source 
Catch ActivityNotFoundException for downloads

 - When trying to forward a download intent to the system catch the exception that is thrown if the system can't handle it to prevent a crash
This commit is contained in:
Joris Pelgröm 2022-11-29 04:12:55 +01:00 committed by GitHub
parent 442cb25e59
commit 71bf6a76f1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/src/main/java/io/homeassistant/companion/android/webview/WebViewActivity.kt
View file

@ -3,6 +3,7 @@ package io.homeassistant.companion.android.webview
import android.annotation.SuppressLint
import android.app.DownloadManager
import android.app.PictureInPictureParams
import android.content.ActivityNotFoundException
import android.content.Context
import android.content.Intent
import android.content.pm.PackageManager
@ -1345,8 +1346,15 @@ class WebViewActivity : BaseActivity(), io.homeassistant.companion.android.webvi
}
else -> {
Log.d(TAG, "Received download request for unsupported scheme, forwarding to system")
val browserIntent = Intent(Intent.ACTION_VIEW, uri)
startActivity(browserIntent)
try {
val browserIntent = Intent(Intent.ACTION_VIEW, uri).apply {
flags = Intent.FLAG_ACTIVITY_NEW_TASK
}
startActivity(browserIntent)
} catch (e: ActivityNotFoundException) {
Log.e(TAG, "Unable to forward download request to system", e)
Toast.makeText(this, commonR.string.failed_unsupported, Toast.LENGTH_SHORT).show()
}
}
}
}