mobile/element-android
mobile/element-android
1
0
Fork 0
mirror of https://github.com/element-hq/element-android synced 2024-07-21 01:54:35 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #6681 from vector-im/fix/mna/leak-tab-layout-mediator

Browse source 
[FTUE] Memory leak on FtueAuthSplashCarouselFragment
This commit is contained in:
Maxime NATUREL 2022-08-03 14:18:41 +02:00 committed by GitHub
parent 4bff816056 2b58c42c8b
commit bfd9dcbca2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/6680.misc Normal file
View file

@ -0,0 +1 @@
[FTUE] Memory leak on FtueAuthSplashCarouselFragment

13
vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthSplashCarouselFragment.kt
View file

@ -52,6 +52,8 @@ class FtueAuthSplashCarouselFragment @Inject constructor(
private val buildMeta: BuildMeta,
) : AbstractFtueAuthFragment<FragmentFtueSplashCarouselBinding>() {
private var tabLayoutMediator: TabLayoutMediator? = null
override fun getBinding(inflater: LayoutInflater, container: ViewGroup?): FragmentFtueSplashCarouselBinding {
return FragmentFtueSplashCarouselBinding.inflate(inflater, container, false)
}
@ -61,10 +63,19 @@ class FtueAuthSplashCarouselFragment @Inject constructor(
setupViews()
}
override fun onDestroyView() {
tabLayoutMediator?.detach()
tabLayoutMediator = null
views.splashCarousel.adapter = null
super.onDestroyView()
}
private fun setupViews() {
val carouselAdapter = carouselController.adapter
views.splashCarousel.adapter = carouselAdapter
TabLayoutMediator(views.carouselIndicator, views.splashCarousel) { _, _ -> }.attach()
tabLayoutMediator = TabLayoutMediator(views.carouselIndicator, views.splashCarousel) { _, _ -> }
.also { it.attach() }
carouselController.setData(carouselStateFactory.create())
val isAlreadyHaveAccountEnabled = vectorFeatures.isOnboardingAlreadyHaveAccountSplashEnabled()