From 67180fd8db3eafd3c0b3bd0786f05a4b54f9878b Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Wed, 26 Feb 2020 07:38:10 +0100 Subject: [PATCH] New direct chat: selecting several participants was not adding the room to the direct chats list --- CHANGES.md | 1 + .../room/model/create/CreateRoomParams.kt | 16 ---------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 7d62e54caa..37b6c63393 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -21,6 +21,7 @@ Bugfix 🐛: - Leaving a room creates a stuck "leaving room" loading screen. (#1041) - Fix some invitation handling issues (#1013) - New direct chat: selecting a participant sometimes results in two breadcrumbs (#1022) + - New direct chat: selecting several participants was not adding the room to the direct chats list Translations 🗣: - diff --git a/matrix-sdk-android/src/main/java/im/vector/matrix/android/api/session/room/model/create/CreateRoomParams.kt b/matrix-sdk-android/src/main/java/im/vector/matrix/android/api/session/room/model/create/CreateRoomParams.kt index af2a5bf1e0..1abbe9ef3a 100644 --- a/matrix-sdk-android/src/main/java/im/vector/matrix/android/api/session/room/model/create/CreateRoomParams.kt +++ b/matrix-sdk-android/src/main/java/im/vector/matrix/android/api/session/room/model/create/CreateRoomParams.kt @@ -216,20 +216,6 @@ data class CreateRoomParams( ) } - /** - * @return the invite count - */ - private fun getInviteCount(): Int { - return invitedUserIds?.size ?: 0 - } - - /** - * @return the pid invite count - */ - private fun getInvite3PidCount(): Int { - return invite3pids?.size ?: 0 - } - /** * Tells if the created room can be a direct chat one. * @@ -238,8 +224,6 @@ data class CreateRoomParams( fun isDirect(): Boolean { return preset == CreateRoomPreset.PRESET_TRUSTED_PRIVATE_CHAT && isDirect == true - // TODO This test is not ok - && (1 == getInviteCount() || 1 == getInvite3PidCount()) } /**