From 09a91c4541965c088bfce3d06deaaef51cc6c3c9 Mon Sep 17 00:00:00 2001 From: Michael Kaye <1917473+michaelkaye@users.noreply.github.com> Date: Thu, 4 Aug 2022 15:54:53 +0100 Subject: [PATCH] Make it easier to find developer sign-off instructions (#6739) * Make it easier to find sign-off instructions by linking directly to DCO docs from danger message. --- changelog.d/6739.misc | 1 + tools/danger/dangerfile.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelog.d/6739.misc diff --git a/changelog.d/6739.misc b/changelog.d/6739.misc new file mode 100644 index 0000000000..5e5de00831 --- /dev/null +++ b/changelog.d/6739.misc @@ -0,0 +1 @@ +Link directly to DCO docs from danger message. diff --git a/tools/danger/dangerfile.js b/tools/danger/dangerfile.js index 59a616db4a..4efd236419 100644 --- a/tools/danger/dangerfile.js +++ b/tools/danger/dangerfile.js @@ -83,7 +83,7 @@ if (requiresSignOff) { const hasPRBodySignOff = pr.body.includes(signOff) const hasCommitSignOff = danger.git.commits.every(commit => commit.message.includes(signOff)) if (!hasPRBodySignOff && !hasCommitSignOff) { - fail("Please add a sign-off to either the PR description or to the commits themselves.") + fail("Please add a sign-off to either the PR description or to the commits themselves. See instructions [here](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off).") } }