TasksActivity: use defaultValue=true for HINT_OPENTASKS_NOT_INSTALLED (#723)

This commit is contained in:
Ricki Hirner 2024-04-12 17:08:37 +02:00 committed by GitHub
parent c0570549c9
commit ee36753e1a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions

View file

@ -154,6 +154,7 @@ class SettingsManager internal constructor(
fun getBooleanOrNull(key: String): Boolean? = getValue(key) { provider -> provider.getBoolean(key) }
fun getBoolean(key: String): Boolean = getBooleanOrNull(key) ?: throw NoSuchPropertyException(key)
fun getBooleanFlow(key: String): Flow<Boolean?> = observerFlow { getBooleanOrNull(key) }
fun getBooleanFlow(key: String, defaultValue: Boolean): Flow<Boolean> = observerFlow { getBooleanOrNull(key) ?: defaultValue }
fun getIntOrNull(key: String): Int? = getValue(key) { provider -> provider.getInt(key) }
fun getInt(key: String): Int = getIntOrNull(key) ?: throw NoSuchPropertyException(key)

View file

@ -104,7 +104,7 @@ class TasksActivity: AppCompatActivity() {
}
val showAgain = settings.getBooleanFlow(HINT_OPENTASKS_NOT_INSTALLED)
val showAgain = settings.getBooleanFlow(HINT_OPENTASKS_NOT_INSTALLED, true)
fun setShowAgain(showAgain: Boolean) {
if (showAgain)
settings.remove(HINT_OPENTASKS_NOT_INSTALLED)
@ -166,7 +166,7 @@ fun TasksCard(
val openTasksInstalled = model.openTasksInstalled
val openTasksSelected by model.openTasksSelected.collectAsStateWithLifecycle(false)
val showAgain = model.showAgain.collectAsStateWithLifecycle(null).value ?: false
val showAgain by model.showAgain.collectAsStateWithLifecycle(true)
fun installApp(packageName: String) {
val uri = Uri.parse("market://details?id=$packageName&referrer=" +