mobile/davx5-ose
mobile/davx5-ose
1
0
Fork 0
mirror of https://github.com/bitfireAT/davx5-ose synced 2024-07-23 11:39:15 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

DavDocumentsProvider: Log a warning for responses of type OTHER. (#400)

Browse source 
If a WebDAV server is misconfigured (for example, behind an HTTP proxy that
strips a URL prefix and doesn't correctly forward this to the WebDAV server)
then PROPFIND can return resources whose URLs don't match the request URL. These
are resolved by dav4jvm as HrefRelation.OTHER.

Currently this situation produces no output at all in DAVx5 (logs or app) and
the WebDAV share appears accessible but empty. It is possible to create files in
the share, but not to see them again afterwards!

Of course a misconfigured server isn't the WebDAV client's responsibility to
resolve, but adding a warning in the log provides an extra clue for anyone
trying to debug it.
This commit is contained in:
Angus Gratton 2023-09-08 21:48:39 +10:00 committed by GitHub
parent 0c991288d5
commit 52e26e34d5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/at/bitfire/davdroid/webdav/DavDocumentsProvider.kt
View file

@ -611,9 +611,11 @@ class DavDocumentsProvider: DocumentsProvider() {
parent
Response.HrefRelation.MEMBER -> // it's about a member
WebDavDocument(mountId = parent.mountId, parentId = parent.id, name = response.hrefName())
else ->
// we didn't request this; ignore it
else -> {
// we didn't request this; log a warning and ignore it
Logger.log.warning("Ignoring unexpected $response $relation in $parentUrl")
return@propfind
}
}
response[ResourceType::class.java]?.types?.let { types ->