From de0b3c8bc205484219c9fca01bb7d6e7df51b66b Mon Sep 17 00:00:00 2001 From: Zhang Hai Date: Sun, 4 Nov 2018 23:25:05 -0800 Subject: [PATCH] [Feature] Add working about page; Closes #36. --- app/build.gradle | 3 +- .../about/AboutFragment.java | 13 ++ .../drawable/google_plus_icon_white_24dp.xml | 18 ++ .../drawable/information_icon_white_24dp.xml | 18 ++ .../res/drawable/person_icon_white_24dp.xml | 18 ++ .../transparent_divider_horizontal_16dp.xml | 10 + app/src/main/res/layout/about_fragment.xml | 202 +++++++++++++++++- .../main/res/layout/file_list_fragment.xml | 2 +- app/src/main/res/values-sw600dp/dimens.xml | 4 +- app/src/main/res/values/dimens.xml | 9 +- app/src/main/res/values/strings.xml | 5 + 11 files changed, 285 insertions(+), 17 deletions(-) create mode 100644 app/src/main/res/drawable/google_plus_icon_white_24dp.xml create mode 100644 app/src/main/res/drawable/information_icon_white_24dp.xml create mode 100644 app/src/main/res/drawable/person_icon_white_24dp.xml create mode 100644 app/src/main/res/drawable/transparent_divider_horizontal_16dp.xml diff --git a/app/build.gradle b/app/build.gradle index b2aa566a..59677c68 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -13,7 +13,8 @@ android { minSdkVersion 21 targetSdkVersion 28 versionCode 1 - versionName '1.0.0' + versionName '1.0.0-alpha.1' + resValue 'string', 'app_version', versionName + ' (' + versionCode + ')' buildConfigField 'String', 'FILE_PROVIDIER_AUTHORITY', 'APPLICATION_ID + ".file_provider"' resValue 'string', 'file_provider_authority', applicationId + '.file_provider' } diff --git a/app/src/main/java/me/zhanghai/android/materialfilemanager/about/AboutFragment.java b/app/src/main/java/me/zhanghai/android/materialfilemanager/about/AboutFragment.java index 175b5488..2f95c751 100644 --- a/app/src/main/java/me/zhanghai/android/materialfilemanager/about/AboutFragment.java +++ b/app/src/main/java/me/zhanghai/android/materialfilemanager/about/AboutFragment.java @@ -29,12 +29,21 @@ public class AboutFragment extends Fragment { private static final Uri GITHUB_URI = Uri.parse( "https://github.com/DreaminginCodeZH/MaterialFileManager"); + private static final Uri AUTHOR_GITHUB_URI = Uri.parse("https://github.com/DreaminginCodeZH"); + + private static final Uri AUTHOR_GOOGLE_PLUS_URI = Uri.parse( + "https://plus.google.com/105148560373589648355"); + @BindView(R.id.toolbar) Toolbar mToolbar; @BindView(R.id.github) ViewGroup mGitHubLayout; @BindView(R.id.licenses) ViewGroup mLicensesLayout; + @BindView(R.id.author_github) + ViewGroup mAuthorGitHubLayout; + @BindView(R.id.author_google_plus) + ViewGroup mAuthorGooglePlusLayout; @NonNull public static AboutFragment newInstance() { @@ -78,6 +87,10 @@ public class AboutFragment extends Fragment { mGitHubLayout.setOnClickListener(view -> AppUtils.startActivity(IntentUtils.makeView( GITHUB_URI), this)); mLicensesLayout.setOnClickListener(view -> LicensesDialogFragment.show(this)); + mAuthorGitHubLayout.setOnClickListener(view -> AppUtils.startActivity(IntentUtils.makeView( + AUTHOR_GITHUB_URI), this)); + mAuthorGooglePlusLayout.setOnClickListener(view -> AppUtils.startActivity( + IntentUtils.makeView(AUTHOR_GOOGLE_PLUS_URI), this)); } @Override diff --git a/app/src/main/res/drawable/google_plus_icon_white_24dp.xml b/app/src/main/res/drawable/google_plus_icon_white_24dp.xml new file mode 100644 index 00000000..58acf55f --- /dev/null +++ b/app/src/main/res/drawable/google_plus_icon_white_24dp.xml @@ -0,0 +1,18 @@ + + + + + + + + diff --git a/app/src/main/res/drawable/information_icon_white_24dp.xml b/app/src/main/res/drawable/information_icon_white_24dp.xml new file mode 100644 index 00000000..dd7dc701 --- /dev/null +++ b/app/src/main/res/drawable/information_icon_white_24dp.xml @@ -0,0 +1,18 @@ + + + + + + + + diff --git a/app/src/main/res/drawable/person_icon_white_24dp.xml b/app/src/main/res/drawable/person_icon_white_24dp.xml new file mode 100644 index 00000000..3dc6a522 --- /dev/null +++ b/app/src/main/res/drawable/person_icon_white_24dp.xml @@ -0,0 +1,18 @@ + + + + + + + + diff --git a/app/src/main/res/drawable/transparent_divider_horizontal_16dp.xml b/app/src/main/res/drawable/transparent_divider_horizontal_16dp.xml new file mode 100644 index 00000000..10af013d --- /dev/null +++ b/app/src/main/res/drawable/transparent_divider_horizontal_16dp.xml @@ -0,0 +1,10 @@ + + + + + + + diff --git a/app/src/main/res/layout/about_fragment.xml b/app/src/main/res/layout/about_fragment.xml index fcb3c8a0..7675d032 100644 --- a/app/src/main/res/layout/about_fragment.xml +++ b/app/src/main/res/layout/about_fragment.xml @@ -29,25 +29,97 @@ + android:showDividers="middle"> + android:paddingTop="@dimen/list_vertical_padding" + android:paddingBottom="@dimen/list_vertical_padding"> + + + + + + + + + + + + + + + + + + + @@ -90,7 +161,6 @@ @@ -106,6 +176,120 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/layout/file_list_fragment.xml b/app/src/main/res/layout/file_list_fragment.xml index 4f535ab8..169660b6 100644 --- a/app/src/main/res/layout/file_list_fragment.xml +++ b/app/src/main/res/layout/file_list_fragment.xml @@ -95,7 +95,7 @@ android:id="@+id/recycler" android:layout_width="match_parent" android:layout_height="match_parent" - android:paddingBottom="@dimen/list_padding_bottom_with_fab" + android:paddingBottom="@dimen/list_bottom_padding_with_fab" android:clipToPadding="false" app:fastScrollEnableThumbInactiveColor="false" app:fastScrollPopupBgColor="?colorAccent" diff --git a/app/src/main/res/values-sw600dp/dimens.xml b/app/src/main/res/values-sw600dp/dimens.xml index 782fd5fb..7b81556d 100644 --- a/app/src/main/res/values-sw600dp/dimens.xml +++ b/app/src/main/res/values-sw600dp/dimens.xml @@ -15,6 +15,6 @@ 68dp 20dp 192dp - @dimen/screen_edge_margin - 2dp + @dimen/screen_edge_margin + @dimen/screen_edge_margin diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index f993097d..09db9d00 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -15,18 +15,19 @@ 60dp 32dp 16dp + 16dp 12dp 24dp 20dp 172dp 48dp - 8dp - 88dp + 8dp + 88dp 72dp 16dp 1dp - 0dp - 0dp + 8dp + 16dp 18dp 24dp 40dp diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 97a56bf4..b04f18c1 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -162,6 +162,7 @@ About + Version View on GitHub Licenses @@ -194,4 +195,8 @@ color: #e91e63; } + Author + Hai Zhang + Follow on GitHub + Add to Google+ circles