mirror of
https://github.com/rust-lang/rust
synced 2024-10-01 14:25:08 +00:00
925f7fad57
`tokenstream::Spacing` appears on all `TokenTree::Token` instances, both punct and non-punct. Its current usage: - `Joint` means "can join with the next token *and* that token is a punct". - `Alone` means "cannot join with the next token *or* can join with the next token but that token is not a punct". The fact that `Alone` is used for two different cases is awkward. This commit augments `tokenstream::Spacing` with a new variant `JointHidden`, resulting in: - `Joint` means "can join with the next token *and* that token is a punct". - `JointHidden` means "can join with the next token *and* that token is a not a punct". - `Alone` means "cannot join with the next token". This *drastically* improves the output of `print_tts`. For example, this: ``` stringify!(let a: Vec<u32> = vec![];) ``` currently produces this string: ``` let a : Vec < u32 > = vec! [] ; ``` With this PR, it now produces this string: ``` let a: Vec<u32> = vec![] ; ``` (The space after the `]` is because `TokenTree::Delimited` currently doesn't have spacing information. The subsequent commit fixes this.) The new `print_tts` doesn't replicate original code perfectly. E.g. multiple space characters will be condensed into a single space character. But it's much improved. `print_tts` still produces the old, uglier output for code produced by proc macros. Because we have to translate the generated code from `proc_macro::Spacing` to the more expressive `token::Spacing`, which results in too much `proc_macro::Along` usage and no `proc_macro::JointHidden` usage. So `space_between` still exists and is used by `print_tts` in conjunction with the `Spacing` field. This change will also help with the removal of `Token::Interpolated`. Currently interpolated tokens are pretty-printed nicely via AST pretty printing. `Token::Interpolated` removal will mean they get printed with `print_tts`. Without this change, that would result in much uglier output for code produced by decl macro expansions. With this change, AST pretty printing and `print_tts` produce similar results. The commit also tweaks the comments on `proc_macro::Spacing`. In particular, it refers to "compound tokens" rather than "multi-char operators" because lifetimes aren't operators.
84 lines
3.4 KiB
Plaintext
84 lines
3.4 KiB
Plaintext
PRINT-DERIVE INPUT (DISPLAY): struct Foo
|
|
{ my_array: [bool; { struct Inner { non_removed_inner_field: usize } 0 }] }
|
|
PRINT-DERIVE DEEP-RE-COLLECTED (DISPLAY): struct Foo
|
|
{ my_array : [bool ; { struct Inner { non_removed_inner_field : usize } 0 }] }
|
|
PRINT-DERIVE INPUT (DEBUG): TokenStream [
|
|
Ident {
|
|
ident: "struct",
|
|
span: $DIR/nested-derive-cfg.rs:12:1: 12:7 (#0),
|
|
},
|
|
Ident {
|
|
ident: "Foo",
|
|
span: $DIR/nested-derive-cfg.rs:12:8: 12:11 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Brace,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "my_array",
|
|
span: $DIR/nested-derive-cfg.rs:14:5: 14:13 (#0),
|
|
},
|
|
Punct {
|
|
ch: ':',
|
|
spacing: Alone,
|
|
span: $DIR/nested-derive-cfg.rs:14:13: 14:14 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Bracket,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "bool",
|
|
span: $DIR/nested-derive-cfg.rs:14:16: 14:20 (#0),
|
|
},
|
|
Punct {
|
|
ch: ';',
|
|
spacing: Alone,
|
|
span: $DIR/nested-derive-cfg.rs:14:20: 14:21 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Brace,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "struct",
|
|
span: $DIR/nested-derive-cfg.rs:15:9: 15:15 (#0),
|
|
},
|
|
Ident {
|
|
ident: "Inner",
|
|
span: $DIR/nested-derive-cfg.rs:15:16: 15:21 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Brace,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "non_removed_inner_field",
|
|
span: $DIR/nested-derive-cfg.rs:17:13: 17:36 (#0),
|
|
},
|
|
Punct {
|
|
ch: ':',
|
|
spacing: Alone,
|
|
span: $DIR/nested-derive-cfg.rs:17:36: 17:37 (#0),
|
|
},
|
|
Ident {
|
|
ident: "usize",
|
|
span: $DIR/nested-derive-cfg.rs:17:38: 17:43 (#0),
|
|
},
|
|
],
|
|
span: $DIR/nested-derive-cfg.rs:15:22: 18:10 (#0),
|
|
},
|
|
Literal {
|
|
kind: Integer,
|
|
symbol: "0",
|
|
suffix: None,
|
|
span: $DIR/nested-derive-cfg.rs:19:9: 19:10 (#0),
|
|
},
|
|
],
|
|
span: $DIR/nested-derive-cfg.rs:14:22: 20:6 (#0),
|
|
},
|
|
],
|
|
span: $DIR/nested-derive-cfg.rs:14:15: 20:7 (#0),
|
|
},
|
|
],
|
|
span: $DIR/nested-derive-cfg.rs:12:12: 21:2 (#0),
|
|
},
|
|
]
|