languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-10-01 14:25:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #126906 - GrigorenkoPV:fixme-split_at_first, r=Mark-Simulacrum

Browse source 
Small fixme in core now that split_first has no codegen issues

https://github.com/rust-lang/rust/issues/109328#issuecomment-1677366881

BTW, I have a crate implementing exactly this kind of an iterator: https://github.com/GrigorenkoPV/head-tail-iter and I was wondering if it would be worthwhile to try and make an ACP for it to get it included in std (or maybe itertools). My only doubt is that it kinda incentives writing O(n^2) algorithms and is not the hard to replace with a `while let` loop (just as in this PR).
This commit is contained in:
Matthias Krüger 2024-06-30 10:39:47 +02:00 committed by GitHub
parent c7aee65edd 39bf1dcce5
commit fe1f83ccd7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
library/core/src/num/dec2flt/common.rs
View file

@ -39,9 +39,7 @@ fn offset_from(&self, other: &Self) -> isize {
fn parse_digits(&self, mut func: impl FnMut(u8)) -> &Self { fn parse_digits(&self, mut func: impl FnMut(u8)) -> &Self {
let mut s = self; let mut s = self;
// FIXME: Can't use s.split_first() here yet, while let Some((c, s_next)) = s.split_first() {
// see https://github.com/rust-lang/rust/issues/109328
while let [c, s_next @ ..] = s {
let c = c.wrapping_sub(b'0'); let c = c.wrapping_sub(b'0');
if c < 10 { if c < 10 {
func(c); func(c);

4
library/core/src/num/dec2flt/parse.rs
View file

@ -51,9 +51,7 @@ fn try_parse_19digits(s_ref: &mut &[u8], x: &mut u64) {
let mut s = *s_ref; let mut s = *s_ref;
while *x < MIN_19DIGIT_INT { while *x < MIN_19DIGIT_INT {
// FIXME: Can't use s.split_first() here yet, if let Some((c, s_next)) = s.split_first() {
// see https://github.com/rust-lang/rust/issues/109328
if let [c, s_next @ ..] = s {
let digit = c.wrapping_sub(b'0'); let digit = c.wrapping_sub(b'0');
if digit < 10 { if digit < 10 {