From c0f86a953ca1fb6e7af0378ea99b3d91f9d50e46 Mon Sep 17 00:00:00 2001 From: Aaron Turon Date: Wed, 1 Apr 2015 11:34:27 -0700 Subject: [PATCH] Re-add min_value, max_value methods Recent numerics stabilization removed the inherent `min_value` and `max_value` methods from integer types, assuming that the module-level constants would suffice. However, that failed to account for the use case in FFI code when dealing with integer type aliases. This commit reintroduces the methods as `#[stable]`, since this is essential functionality for 1.0. It's unfortunate to freeze these as methods, but when we can provide inherent associated constants these methods can be deprecated. --- src/libcore/num/mod.rs | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/libcore/num/mod.rs b/src/libcore/num/mod.rs index a4829ed96b3..337f2c4a173 100644 --- a/src/libcore/num/mod.rs +++ b/src/libcore/num/mod.rs @@ -820,6 +820,18 @@ macro_rules! int_impl { $add_with_overflow:path, $sub_with_overflow:path, $mul_with_overflow:path) => { + /// Returns the smallest value that can be represented by this integer type. + #[stable(feature = "rust1", since = "1.0.0")] + pub fn min_value() -> $T { + (-1 as $T) << ($BITS - 1) + } + + /// Returns the largest value that can be represented by this integer type. + #[stable(feature = "rust1", since = "1.0.0")] + pub fn max_value() -> $T { + let min: $T = Int::min_value(); !min + } + /// Convert a string slice in a given base to an integer. /// /// Leading and trailing whitespace represent an error. @@ -1330,6 +1342,14 @@ macro_rules! uint_impl { $add_with_overflow:path, $sub_with_overflow:path, $mul_with_overflow:path) => { + /// Returns the smallest value that can be represented by this integer type. + #[stable(feature = "rust1", since = "1.0.0")] + pub fn min_value() -> $T { 0 } + + /// Returns the largest value that can be represented by this integer type. + #[stable(feature = "rust1", since = "1.0.0")] + pub fn max_value() -> $T { -1 } + /// Convert a string slice in a given base to an integer. /// /// Leading and trailing whitespace represent an error.