languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-10-22 08:24:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #78352 - JohnTitor:issue-75229, r=Dylan-DPC

Browse source 
Do not call `unwrap` with `signatures` option enabled

Fixes #75229
Didn't add a test since I couldn't set `RUST_SAVE_ANALYSIS_CONFIG` even with `rustc-env`.
This commit is contained in:
Dylan DPC 2020-11-15 03:02:34 +01:00 committed by GitHub
parent 361c4ea224 3dd0a7d6eb
commit dc4d65579c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_save_analysis/src/sig.rs
View file

@ -21,7 +21,7 @@
// references.
//
// Signatures do not include visibility info. I'm not sure if this is a feature
// or an ommission (FIXME).
// or an omission (FIXME).
//
// FIXME where clauses need implementing, defs/refs in generics are mostly missing.
@ -677,7 +677,7 @@ fn make(&self, offset: usize, parent_id: Option<hir::HirId>, scx: &SaveContext<'
let mut text = self.ident.to_string();
match self.data {
hir::VariantData::Struct(fields, r) => {
let id = parent_id.unwrap();
let id = parent_id.ok_or("Missing id for Variant's parent")?;
let name_def = SigElement {
id: id_from_hir_id(id, scx),
start: offset,