languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-10-02 06:44:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Auto merge of #114649 - Kobzol:bolt-remove-use-old-text, r=nikic

Browse source 
Remove usage of `--use-old-text` for BOLT

This flag has [reduced](https://github.com/rust-lang/rust/pull/114141) the size of `libLLVM.so` by ~50 MiB, but sadly it is quite non-deterministic and the size savings frequently fail, thus causing large artifact size [swings](https://github.com/rust-lang/rust/pull/114297#issuecomment-1670292387). To avoid the swings, it would be better to just disable the flag for now.

r? `@nikic`
This commit is contained in:
bors 2023-08-09 10:41:15 +00:00
parent 19a647d6d8 6b4ec09cab
commit d190d97864
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/tools/opt-dist/src/bolt.rs
View file

@ -65,8 +65,13 @@ pub fn bolt_optimize(path: &Utf8Path, profile: &LlvmBoltProfile) -> anyhow::Resu
.arg("-jump-tables=move")
// Fold functions with identical code
.arg("-icf=1")
// The following flag saves about 50 MiB of libLLVM.so size.
// However, it succeeds very non-deterministically. To avoid frequent artifact size swings,
// it is kept disabled for now.
// FIXME(kobzol): try to re-enable this once BOLT in-place rewriting is merged or after
// we bump LLVM.
// Try to reuse old text segments to reduce binary size
.arg("--use-old-text")
// .arg("--use-old-text")
// Update DWARF debug info in the final binary
.arg("-update-debug-sections")
// Print optimization statistics