languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-10-14 04:23:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

rustc: Do argument casts before loading aggregates, not after

Browse source
This commit is contained in:
Patrick Walton 2011-03-19 13:58:48 -07:00
parent 3f2bae4449
commit c710c9a1b8
1 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/comp/middle/trans.rs
View file

@ -4029,11 +4029,6 @@ fn trans_args(@block_ctxt cx,
auto re = trans_expr(bcx, e);
val = re.val;
bcx = re.bcx;
if (mode == ast.val) {
// Until here we've been treating structures by pointer;
// we are now passing it as an arg, so need to load it.
val = bcx.build.Load(val);
}
} else if (mode == ast.alias) {
let lval_result lv;
if (ty.is_lval(e)) {
@ -4063,9 +4058,25 @@ fn trans_args(@block_ctxt cx,
if (ty.count_ty_params(args.(i).ty) > 0u) {
auto lldestty = arg_tys.(i);
if (mode == ast.val) {
// FIXME: we'd prefer to use &&, but rustboot doesn't like it
if (ty.type_is_structural(ty.expr_ty(e))) {
lldestty = T_ptr(lldestty);
}
}
val = bcx.build.PointerCast(val, lldestty);
}
if (mode == ast.val) {
// FIXME: we'd prefer to use &&, but rustboot doesn't like it
if (ty.type_is_structural(ty.expr_ty(e))) {
// Until here we've been treating structures by pointer;
// we are now passing it as an arg, so need to load it.
val = bcx.build.Load(val);
}
}
llargs += vec(val);
i += 1u;
}