languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-09-30 22:04:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Auto merge of #110935 - scottmcm:always-ord, r=Mark-Simulacrum

Browse source 
`inline(always)` for `lt`/`le`/`ge`/`gt` on integers and floats

I happened to notice one of these not getting inlined as part of `Range::next` in <https://rust.godbolt.org/z/4WKWWxj1G>
```rust
    bb1: {
        StorageLive(_5);
        _6 = &mut _4;
        StorageLive(_21);
        StorageLive(_14);
        StorageLive(_15);
        _15 = &((*_6).0: usize);
        StorageLive(_16);
        _16 = &((*_6).1: usize);
        _14 = <usize as PartialOrd>::lt(move _15, move _16) -> bb7;
    }
```

So since a call for something that's just one instruction is never the right choice, `#[inline(always)]` seems appropriate, like we have it on things like the rotate methods on integers.
This commit is contained in:
bors 2023-04-30 07:43:18 +00:00
parent d3edfd18c7 8857cc2131
commit c1bb0e0911
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
library/core/src/cmp.rs
View file

@ -1321,13 +1321,13 @@ fn partial_cmp(&self, other: &$t) -> Option<Ordering> {
(true, true) => Some(Equal),
}
}
#[inline]
#[inline(always)]
fn lt(&self, other: &$t) -> bool { (*self) < (*other) }
#[inline]
#[inline(always)]
fn le(&self, other: &$t) -> bool { (*self) <= (*other) }
#[inline]
#[inline(always)]
fn ge(&self, other: &$t) -> bool { (*self) >= (*other) }
#[inline]
#[inline(always)]
fn gt(&self, other: &$t) -> bool { (*self) > (*other) }
}
)*)
@ -1359,13 +1359,13 @@ impl PartialOrd for $t {
fn partial_cmp(&self, other: &$t) -> Option<Ordering> {
Some(self.cmp(other))
}
#[inline]
#[inline(always)]
fn lt(&self, other: &$t) -> bool { (*self) < (*other) }
#[inline]
#[inline(always)]
fn le(&self, other: &$t) -> bool { (*self) <= (*other) }
#[inline]
#[inline(always)]
fn ge(&self, other: &$t) -> bool { (*self) >= (*other) }
#[inline]
#[inline(always)]
fn gt(&self, other: &$t) -> bool { (*self) > (*other) }
}