Suggest deref on comparison binop RHS even if type is not Copy

This commit is contained in:
Michael Goulet 2023-04-19 16:47:06 +00:00
parent de96f3d873
commit b0a7d6e4b7
3 changed files with 29 additions and 1 deletions

View file

@ -1508,6 +1508,12 @@ pub fn check_ref(
// FIXME(compiler-errors): We can actually do this if the checked_ty is
// `steps` layers of boxes, not just one, but this is easier and most likely.
|| (checked_ty.is_box() && steps == 1)
// We can always deref a binop that takes its arguments by ref.
|| matches!(
self.tcx.hir().get_parent(expr.hir_id),
hir::Node::Expr(hir::Expr { kind: hir::ExprKind::Binary(op, ..), .. })
if !op.node.is_by_value()
)
{
let deref_kind = if checked_ty.is_box() {
"unboxing the value"

View file

@ -72,4 +72,13 @@ fn main() {
} else {
&0
};
#[derive(PartialEq, Eq)]
struct Foo;
let foo = Foo;
let bar = &Foo;
if foo == bar {
//~^ ERROR mismatched types
}
}

View file

@ -175,6 +175,19 @@ LL | || };
| |_____`if` and `else` have incompatible types
| expected `i32`, found `&{integer}`
error: aborting due to 13 previous errors
error[E0308]: mismatched types
--> $DIR/deref-suggestion.rs:81:15
|
LL | if foo == bar {
| --- ^^^ expected `Foo`, found `&Foo`
| |
| expected because this is `Foo`
|
help: consider dereferencing the borrow
|
LL | if foo == *bar {
| +
error: aborting due to 14 previous errors
For more information about this error, try `rustc --explain E0308`.