languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-10-14 12:33:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adjust spans correctly for fn -> method suggestion

Browse source
This commit is contained in:
Michael Goulet 2023-07-27 16:50:28 +00:00
parent b73e9a48ae
commit b09091c69b
3 changed files with 27 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_hir_typeck/src/callee.rs
View file

@ -531,8 +531,12 @@ fn suggest_call_as_method(
return;
}
let up_to_rcvr_span = segment.ident.span.until(callee_expr.span);
let rest_span = callee_expr.span.shrink_to_hi().to(call_expr.span.shrink_to_hi());
let Some(callee_expr_span) = callee_expr.span.find_ancestor_inside(call_expr.span)
else {
return;
};
let up_to_rcvr_span = segment.ident.span.until(callee_expr_span);
let rest_span = callee_expr_span.shrink_to_hi().to(call_expr.span.shrink_to_hi());
let rest_snippet = if let Some(first) = rest.first() {
self.tcx
.sess

6
tests/ui/methods/suggest-method-on-call-with-macro-rcvr.rs Normal file
View file

@ -0,0 +1,6 @@
// issue: 114131
fn main() {
let hello = len(vec![]);
//~^ ERROR cannot find function `len` in this scope
}

15
tests/ui/methods/suggest-method-on-call-with-macro-rcvr.stderr Normal file
View file

@ -0,0 +1,15 @@
error[E0425]: cannot find function `len` in this scope
--> $DIR/suggest-method-on-call-with-macro-rcvr.rs:4:17
|
LL | let hello = len(vec![]);
| ^^^ not found in this scope
|
help: use the `.` operator to call the method `len` on `&Vec<_>`
|
LL - let hello = len(vec![]);
LL + let hello = vec![].len();
|
error: aborting due to previous error
For more information about this error, try `rustc --explain E0425`.