languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-10-14 12:33:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #120641 - klensy:copypaste-me, r=notriddle

Browse source 
rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order

Can be tested by running `cargo doc` with different rust versions on some crate and comparing `doc` folders: files in `trait.impl` and `type.impl` will sometimes have different order of impls.
This commit is contained in:
Matthias Krüger 2024-02-05 06:37:17 +01:00 committed by GitHub
parent bc98f5795b cb4e69ad67
commit a2d3eed58d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/librustdoc/html/render/write_shared.rs
View file

@ -593,11 +593,17 @@ fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
ret
})
.collect::<Vec<_>>();
let impls = format!(
r#""{}":{}"#,
krate.name(cx.tcx()),
serde_json::to_string(&impls).expect("failed serde conversion"),
);
// FIXME: this fixes only rustdoc part of instability of trait impls
// for js files, see #120371
// Manually collect to string and sort to make list not depend on order
let mut impls = impls
.iter()
.map(|i| serde_json::to_string(i).expect("failed serde conversion"))
.collect::<Vec<_>>();
impls.sort();
let impls = format!(r#""{}":[{}]"#, krate.name(cx.tcx()), impls.join(","));
let mut mydst = dst.clone();
for part in &aliased_type.target_fqp[..aliased_type.target_fqp.len() - 1] {
@ -702,11 +708,16 @@ fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
continue;
}
let implementors = format!(
r#""{}":{}"#,
krate.name(cx.tcx()),
serde_json::to_string(&implementors).expect("failed serde conversion"),
);
// FIXME: this fixes only rustdoc part of instability of trait impls
// for js files, see #120371
// Manually collect to string and sort to make list not depend on order
let mut implementors = implementors
.iter()
.map(|i| serde_json::to_string(i).expect("failed serde conversion"))
.collect::<Vec<_>>();
implementors.sort();
let implementors = format!(r#""{}":[{}]"#, krate.name(cx.tcx()), implementors.join(","));
let mut mydst = dst.clone();
for part in &remote_path[..remote_path.len() - 1] {