Include type name in symbol for methods

This commit is contained in:
Seo Sanghyeon 2015-12-12 00:01:08 +09:00
parent 81dd3824ff
commit 87405751ae
4 changed files with 31 additions and 6 deletions

View file

@ -122,7 +122,7 @@ fn visit_item(&mut self, i: &'ast Item) {
// Pick the def data. This need not be unique, but the more
// information we encapsulate into
let def_data = match i.node {
ItemDefaultImpl(..) | ItemImpl(..) => DefPathData::Impl,
ItemDefaultImpl(..) | ItemImpl(..) => DefPathData::Impl(i.name),
ItemEnum(..) | ItemStruct(..) | ItemTrait(..) => DefPathData::Type(i.name),
ItemExternCrate(..) | ItemMod(..) => DefPathData::Mod(i.name),
ItemStatic(..) | ItemConst(..) | ItemFn(..) => DefPathData::Value(i.name),

View file

@ -73,7 +73,7 @@ pub enum DefPathData {
Misc,
// Different kinds of items and item-like things:
Impl,
Impl(ast::Name),
Type(ast::Name),
Mod(ast::Name),
Value(ast::Name),
@ -177,6 +177,7 @@ impl DefPathData {
pub fn as_interned_str(&self) -> InternedString {
use self::DefPathData::*;
match *self {
Impl(name) |
Type(name) |
Mod(name) |
Value(name) |
@ -212,10 +213,6 @@ pub fn as_interned_str(&self) -> InternedString {
InternedString::new("?")
}
Impl => {
InternedString::new("<impl>")
}
ClosureExpr => {
InternedString::new("<closure>")
}

View file

@ -0,0 +1,9 @@
-include ../tools.mk
# Check that symbol names for methods include type names, instead of <impl>.
OUT=$(TMPDIR)/lib.s
all:
$(RUSTC) --crate-type staticlib --emit asm lib.rs
grep Def $(OUT)

View file

@ -0,0 +1,19 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
pub struct Def {
pub id: i32,
}
impl Def {
pub fn new(id: i32) -> Def {
Def { id: id }
}
}