Make sure cold code is as small as possible

This commit is contained in:
Dániel Buga 2020-10-11 20:43:38 +02:00
parent 5565241f65
commit 86e030391b

View file

@ -526,7 +526,6 @@ fn inlined_mark_dependents_as_waiting(&self, node: &Node<O>) {
let node = &self.nodes[index];
let state = node.state.get();
if state == NodeState::Success {
node.state.set(NodeState::Waiting);
// This call site is cold.
self.uninlined_mark_dependents_as_waiting(node);
} else {
@ -538,6 +537,8 @@ fn inlined_mark_dependents_as_waiting(&self, node: &Node<O>) {
// This never-inlined function is for the cold call site.
#[inline(never)]
fn uninlined_mark_dependents_as_waiting(&self, node: &Node<O>) {
// Mark node Waiting in the cold uninlined code instead of the hot inlined
node.state.set(NodeState::Waiting);
self.inlined_mark_dependents_as_waiting(node)
}