From 7781636fc7bd2edc6bf314dc15eb8e9d5cb60ce6 Mon Sep 17 00:00:00 2001 From: Jacob Hoffman-Andrews Date: Tue, 11 Jan 2022 14:39:51 -0800 Subject: [PATCH] Link sidebar "location" heading to top of page This makes it easy, when you are scrolled far down in a page, to jump back to the top. --- src/librustdoc/html/render/mod.rs | 2 +- src/test/rustdoc-gui/sidebar.goml | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/librustdoc/html/render/mod.rs b/src/librustdoc/html/render/mod.rs index dda74904931..0fdf67124c1 100644 --- a/src/librustdoc/html/render/mod.rs +++ b/src/librustdoc/html/render/mod.rs @@ -1737,7 +1737,7 @@ fn print_sidebar(cx: &Context<'_>, it: &clean::Item, buffer: &mut Buffer) { { write!( buffer, - "

{}{}

", + "

{}{}

", match *it.kind { clean::StructItem(..) => "Struct ", clean::TraitItem(..) => "Trait ", diff --git a/src/test/rustdoc-gui/sidebar.goml b/src/test/rustdoc-gui/sidebar.goml index f9c707f81e7..9289244f6f8 100644 --- a/src/test/rustdoc-gui/sidebar.goml +++ b/src/test/rustdoc-gui/sidebar.goml @@ -22,6 +22,13 @@ click: "#structs + .item-table .item-left > a" assert-count: (".sidebar .location", 2) // We check that there is no crate listed outside of the top level. assert-false: ".sidebar-elems > .crate" + +click: ".sidebar-links a" +assert-property: ("html", {"scrollTop": "389"}) + +click: ".sidebar h2.location" +assert-property: ("html", {"scrollTop": "0"}) + // We now go back to the crate page to click on the "lib2" crate link. goto: file://|DOC_PATH|/test_docs/index.html click: ".sidebar-elems .crate > ul > li:first-child > a"