languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-11-05 20:45:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Save and restore xmm regs across the call to UPCALL_NEW_STACK during __morestack, close #1388.

Browse source
This commit is contained in:
Graydon Hoare 2011-12-29 11:49:29 -08:00
parent 884adf38a1
commit 5fd0a3be0c
2 changed files with 30 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/rt/arch/i386/morestack.S
View file

@ -150,6 +150,9 @@ MORESTACK:
movl %ecx, 16(%esp)
movl %edx, 12(%esp)
// FIXME (1388): it's possible we also need to save/restore some
// SSE2 registers here, if floats-go-in-regs on x86+SSE2. Unclear.
// FIXME (1226): main is compiled with the split-stack prologue,
// causing it to call __morestack, so we have to jump back out
calll RUST_GET_TASK

28
src/rt/arch/x86_64/morestack.S
View file

@ -61,6 +61,19 @@ MORESTACK:
pushq %r8
pushq %r9
pushq $0 // Alignment
pushq $0 // Alignment
subq $128, %rsp
movdqa %xmm0, (%rsp)
movdqa %xmm1, 16(%rsp)
movdqa %xmm2, 32(%rsp)
movdqa %xmm3, 48(%rsp)
movdqa %xmm4, 64(%rsp)
movdqa %xmm5, 80(%rsp)
movdqa %xmm6, 96(%rsp)
movdqa %xmm7, 112(%rsp)
// Calculate the address of the stack arguments.
// We have the base pointer, __morestack's return address,
// and __morestack's caller's return address to skip
@ -72,7 +85,7 @@ MORESTACK:
movq %r11, %rdx // Size of stack arguments
movq %rax, %rsi // Address of stack arguments
movq %r10, %rdi // The amount of stack needed
#ifdef __APPLE__
call UPCALL_NEW_STACK
#endif
@ -81,6 +94,19 @@ MORESTACK:
#endif
// Pop the saved arguments
movdqa (%rsp), %xmm0
movdqa 16(%rsp), %xmm1
movdqa 32(%rsp), %xmm2
movdqa 48(%rsp), %xmm3
movdqa 64(%rsp), %xmm4
movdqa 80(%rsp), %xmm5
movdqa 96(%rsp), %xmm6
movdqa 112(%rsp), %xmm7
addq $128, %rsp
popq %r9 // Alignment
popq %r9 // Alignment
popq %r9
popq %r8
popq %rcx