diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d921286ba34..79aba249111 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -293,6 +293,7 @@ jobs: MACOSX_DEPLOYMENT_TARGET: 10.7 NO_LLVM_ASSERTIONS: 1 NO_DEBUG_ASSERTIONS: 1 + NO_OVERFLOW_CHECKS: 1 DIST_REQUIRE_ALL_TOOLS: 1 os: macos-latest - name: dist-x86_64-apple-alt @@ -303,6 +304,7 @@ jobs: MACOSX_DEPLOYMENT_TARGET: 10.7 NO_LLVM_ASSERTIONS: 1 NO_DEBUG_ASSERTIONS: 1 + NO_OVERFLOW_CHECKS: 1 os: macos-latest - name: x86_64-apple env: @@ -313,6 +315,7 @@ jobs: MACOSX_STD_DEPLOYMENT_TARGET: 10.7 NO_LLVM_ASSERTIONS: 1 NO_DEBUG_ASSERTIONS: 1 + NO_OVERFLOW_CHECKS: 1 os: macos-latest - name: dist-aarch64-apple env: @@ -324,6 +327,7 @@ jobs: MACOSX_STD_DEPLOYMENT_TARGET: 11.0 NO_LLVM_ASSERTIONS: 1 NO_DEBUG_ASSERTIONS: 1 + NO_OVERFLOW_CHECKS: 1 DIST_REQUIRE_ALL_TOOLS: 1 JEMALLOC_SYS_WITH_LG_PAGE: 14 os: macos-latest diff --git a/src/ci/docker/host-x86_64/disabled/asmjs/Dockerfile b/src/ci/docker/host-x86_64/disabled/asmjs/Dockerfile index e04f6409f54..07dcb9ea928 100644 --- a/src/ci/docker/host-x86_64/disabled/asmjs/Dockerfile +++ b/src/ci/docker/host-x86_64/disabled/asmjs/Dockerfile @@ -40,3 +40,4 @@ ENV SCRIPT python3 ../x.py --stage 2 test --host='' --target $TARGETS # running with assertions again is not useful ENV NO_DEBUG_ASSERTIONS=1 ENV NO_LLVM_ASSERTIONS=1 +ENV NO_OVERFLOW_CHECKS=1 diff --git a/src/ci/docker/host-x86_64/test-various/Dockerfile b/src/ci/docker/host-x86_64/test-various/Dockerfile index ad0e8e9f928..4d4953fa0e2 100644 --- a/src/ci/docker/host-x86_64/test-various/Dockerfile +++ b/src/ci/docker/host-x86_64/test-various/Dockerfile @@ -39,6 +39,7 @@ ENV RUST_CONFIGURE_ARGS \ # otherwise normally be. We already test libstd with debug assertions in lots of # other contexts as well ENV NO_DEBUG_ASSERTIONS=1 +ENV NO_OVERFLOW_CHECKS=1 ENV WASM_TARGETS=wasm32-unknown-unknown ENV WASM_SCRIPT python3 /checkout/x.py --stage 2 test --host='' --target $WASM_TARGETS \ diff --git a/src/ci/github-actions/ci.yml b/src/ci/github-actions/ci.yml index eb16cf3c762..82f184669ee 100644 --- a/src/ci/github-actions/ci.yml +++ b/src/ci/github-actions/ci.yml @@ -456,6 +456,7 @@ jobs: MACOSX_DEPLOYMENT_TARGET: 10.7 NO_LLVM_ASSERTIONS: 1 NO_DEBUG_ASSERTIONS: 1 + NO_OVERFLOW_CHECKS: 1 DIST_REQUIRE_ALL_TOOLS: 1 <<: *job-macos-xl @@ -467,6 +468,7 @@ jobs: MACOSX_DEPLOYMENT_TARGET: 10.7 NO_LLVM_ASSERTIONS: 1 NO_DEBUG_ASSERTIONS: 1 + NO_OVERFLOW_CHECKS: 1 <<: *job-macos-xl - name: x86_64-apple @@ -478,6 +480,7 @@ jobs: MACOSX_STD_DEPLOYMENT_TARGET: 10.7 NO_LLVM_ASSERTIONS: 1 NO_DEBUG_ASSERTIONS: 1 + NO_OVERFLOW_CHECKS: 1 <<: *job-macos-xl # This target only needs to support 11.0 and up as nothing else supports the hardware @@ -499,6 +502,7 @@ jobs: MACOSX_STD_DEPLOYMENT_TARGET: 11.0 NO_LLVM_ASSERTIONS: 1 NO_DEBUG_ASSERTIONS: 1 + NO_OVERFLOW_CHECKS: 1 DIST_REQUIRE_ALL_TOOLS: 1 # Corresponds to 16K page size # diff --git a/src/ci/run.sh b/src/ci/run.sh index b5019d83af4..3644269a0f6 100755 --- a/src/ci/run.sh +++ b/src/ci/run.sh @@ -89,6 +89,11 @@ else RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-debug-assertions" fi + # Same for overflow checks + if [ "$NO_OVERFLOW_CHECKS" = "" ]; then + RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-overflow-checks" + fi + # In general we always want to run tests with LLVM assertions enabled, but not # all platforms currently support that, so we have an option to disable. if [ "$NO_LLVM_ASSERTIONS" = "" ]; then