languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-10-19 23:13:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use > rather than == for overflow check in scoped threads.

Browse source 
Co-authored-by: Jacob Lifshay <programmerjake@gmail.com>
This commit is contained in:
Mara Bos 2022-01-04 15:58:29 +00:00 committed by GitHub
parent c5cb2def06
commit 2c8cc70ea0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
library/std/src/thread/scoped.rs
View file

@ -29,7 +29,7 @@ impl ScopeData {
pub(super) fn increment_n_running_threads(&self) {
// We check for 'overflow' with usize::MAX / 2, to make sure there's no
// chance it overflows to 0, which would result in unsoundness.
if self.n_running_threads.fetch_add(1, Ordering::Relaxed) == usize::MAX / 2 {
if self.n_running_threads.fetch_add(1, Ordering::Relaxed) > usize::MAX / 2 {
// This can only reasonably happen by mem::forget()'ing many many ScopedJoinHandles.
self.decrement_n_running_threads(false);
panic!("too many running threads in thread scope");