Address review comments and add back some #[inline] attrs from removed commits.

This commit is contained in:
Michael Woerister 2024-01-04 13:51:06 +01:00
parent 900a11bbec
commit 077540cedf
2 changed files with 2 additions and 2 deletions

View file

@ -159,6 +159,7 @@ pub fn into_sorted_stable_ord_by_key<K, C>(self, project_to_key: C) -> Vec<T>
self.collect_stable_ord_by_key(project_to_key) self.collect_stable_ord_by_key(project_to_key)
} }
#[inline]
pub fn collect_sorted<HCX, C>(self, hcx: &HCX, cache_sort_key: bool) -> C pub fn collect_sorted<HCX, C>(self, hcx: &HCX, cache_sort_key: bool) -> C
where where
T: ToStableHashKey<HCX>, T: ToStableHashKey<HCX>,
@ -178,6 +179,7 @@ pub fn collect_sorted<HCX, C>(self, hcx: &HCX, cache_sort_key: bool) -> C
items items
} }
#[inline]
pub fn collect_stable_ord_by_key<K, C, P>(self, project_to_key: P) -> C pub fn collect_stable_ord_by_key<K, C, P>(self, project_to_key: P) -> C
where where
K: StableCompare, K: StableCompare,

View file

@ -1052,8 +1052,6 @@ fn check_features<'tcx>(
tcx.dcx().emit_err(errors::UnknownFeature { span, feature: *feature }); tcx.dcx().emit_err(errors::UnknownFeature { span, feature: *feature });
} }
// We only use the hash map contents to emit errors, and the order of
// emitted errors do not affect query stability.
for (&implied_by, &feature) in remaining_implications.to_sorted_stable_ord() { for (&implied_by, &feature) in remaining_implications.to_sorted_stable_ord() {
let local_defined_features = tcx.lib_features(LOCAL_CRATE); let local_defined_features = tcx.lib_features(LOCAL_CRATE);
let span = local_defined_features let span = local_defined_features