2019-07-02 21:30:28 +00:00
|
|
|
//@ build-pass (FIXME(62277): could be check-pass?)
|
in which inferable outlives-requirements are linted
RFC 2093 (tracking issue #44493) lets us leave off
commonsensically inferable `T: 'a` outlives requirements. (A separate
feature-gate was split off for the case of 'static lifetimes, for
which questions still remain.) Detecting these was requested as an
idioms-2018 lint.
It turns out that issuing a correct, autofixable suggestion here is
somewhat subtle in the presence of other bounds and generic
parameters. Basically, we want to handle these three cases:
• One outlives-bound. We want to drop the bound altogether, including
the colon—
MyStruct<'a, T: 'a>
^^^^ help: remove this bound
• An outlives bound first, followed by a trait bound. We want to
delete the outlives bound and the following plus sign (and
hopefully get the whitespace right, too)—
MyStruct<'a, T: 'a + MyTrait>
^^^^^ help: remove this bound
• An outlives bound after a trait bound. We want to delete the
outlives lifetime and the preceding plus sign—
MyStruct<'a, T: MyTrait + 'a>
^^^^^ help: remove this bound
This gets (slightly) even more complicated in the case of where
clauses, where we want to drop the where clause altogether if there's
just the one bound. Hopefully the comments are enough to explain
what's going on!
A script (in Python, sorry) was used to generate the
hopefully-sufficiently-exhaustive UI test input. Some of these are
split off into a different file because rust-lang-nursery/rustfix#141
(and, causally upstream of that, #53934) prevents them from being
`run-rustfix`-tested.
We also make sure to include a UI test of a case (copied from RFC
2093) where the outlives-bound can't be inferred. Special thanks to
Niko Matsakis for pointing out the `inferred_outlives_of` query,
rather than blindly stripping outlives requirements as if we weren't a
production compiler and didn't care.
This concerns #52042.
2018-08-26 19:22:04 +00:00
|
|
|
|
|
|
|
|
#![allow(unused)]
|
|
|
|
|
#![deny(explicit_outlives_requirements)]
|
|
|
|
|
|
|
|
|
|
// A case where we can't infer the outlives requirement. Example copied from
|
|
|
|
|
// RFC 2093.
|
|
|
|
|
// (https://rust-lang.github.io/rfcs/2093-infer-outlives.html
|
|
|
|
|
// #where-explicit-annotations-would-still-be-required)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
trait MakeRef<'a> {
|
|
|
|
|
type Type;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a, T> MakeRef<'a> for Vec<T>
|
|
|
|
|
where T: 'a // still required
|
|
|
|
|
{
|
|
|
|
|
type Type = &'a T;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
struct Foo<'a, T>
|
|
|
|
|
where T: 'a // still required, not inferred from `field`
|
|
|
|
|
{
|
|
|
|
|
field: <Vec<T> as MakeRef<'a>>::Type
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
fn main() {}
|