languages/rust
languages/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust synced 2024-10-01 14:25:08 +00:00
Code Issues Packages Projects Releases Wiki Activity
rust/tests/ui/span/issue-23338-locals-die-before-temps-of-body.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

49 lines
2 KiB
Plaintext
Raw Normal View History

Add new error codes and update tests
2017-05-27 17:58:52 +00:00
error[E0597]: `y` does not live long enough
Remove licenses
2018-12-25 15:56:47 +00:00
--> $DIR/issue-23338-locals-die-before-temps-of-body.rs:10:5
improve "Doesn't live long enough" error
2016-10-14 15:55:45 +00:00
|
Account for method call and indexing when looking for inner-most path in expression
2023-01-17 02:52:43 +00:00
LL | let y = x;
| - binding `y` declared here
Update UI tests
2018-02-23 00:42:32 +00:00
LL | y.borrow().clone()
Do not set up wrong span for adjustments
2023-06-22 20:30:23 +00:00
| ^---------
update tests for migrate mode by default
2019-04-22 07:40:08 +00:00
| |
| borrowed value does not live long enough
| a temporary with access to the borrow is created here ...
Update UI tests
2018-02-23 00:42:32 +00:00
LL | }
update tests for migrate mode by default
2019-04-22 07:40:08 +00:00
| -
| |
| `y` dropped here while still borrowed
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 07:40:56 +00:00
| ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `Ref<'_, String>`
improve "Doesn't live long enough" error
2016-10-14 15:55:45 +00:00
|
Suggest `;` or assignment to drop borrows in tail exprs Address the diagnostics part of #70844. ``` error[E0597]: `counter` does not live long enough --> $DIR/issue-54556-niconii.rs:22:20 | LL | if let Ok(_) = counter.lock() { } | ^^^^^^^------- | | | borrowed value does not live long enough | a temporary with access to the borrow is created here ... ... LL | } | - | | | `counter` dropped here while still borrowed | ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `std::result::Result<MutexGuard<'_>, ()>` | help: consider adding semicolon after the expression so its temporaries are dropped sooner, before the local variables declared by the block are dropped | LL | if let Ok(_) = counter.lock() { }; | ^ ```
2020-04-16 19:43:40 +00:00
= note: the temporary is part of an expression at the end of a block;
consider forcing this temporary to be dropped sooner, before the block's local variables are dropped
help: for example, you could save the expression's value in a new local variable `x` and then make `x` be the expression at the end of the block
|
LL | let x = y.borrow().clone(); x
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-22 02:07:19 +00:00
| +++++++ +++
improve "Doesn't live long enough" error
2016-10-14 15:55:45 +00:00
Add new error codes and update tests
2017-05-27 17:58:52 +00:00
error[E0597]: `y` does not live long enough
Remove licenses
2018-12-25 15:56:47 +00:00
--> $DIR/issue-23338-locals-die-before-temps-of-body.rs:17:9
improve "Doesn't live long enough" error
2016-10-14 15:55:45 +00:00
|
Account for method call and indexing when looking for inner-most path in expression
2023-01-17 02:52:43 +00:00
LL | let y = x;
| - binding `y` declared here
Update UI tests
2018-02-23 00:42:32 +00:00
LL | y.borrow().clone()
Do not set up wrong span for adjustments
2023-06-22 20:30:23 +00:00
| ^---------
update tests for migrate mode by default
2019-04-22 07:40:08 +00:00
| |
| borrowed value does not live long enough
| a temporary with access to the borrow is created here ...
Update UI tests
2018-02-23 00:42:32 +00:00
LL | };
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 07:40:56 +00:00
| -- ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `Ref<'_, String>`
improve "Doesn't live long enough" error
2016-10-14 15:55:45 +00:00
| |
Improve "Doesn't live long enough" error case with different lifetime with spans
2016-10-26 16:10:39 +00:00
| `y` dropped here while still borrowed
update tests for migrate mode by default
2019-04-22 07:40:08 +00:00
|
Suggest `;` or assignment to drop borrows in tail exprs Address the diagnostics part of #70844. ``` error[E0597]: `counter` does not live long enough --> $DIR/issue-54556-niconii.rs:22:20 | LL | if let Ok(_) = counter.lock() { } | ^^^^^^^------- | | | borrowed value does not live long enough | a temporary with access to the borrow is created here ... ... LL | } | - | | | `counter` dropped here while still borrowed | ... and the borrow might be used here, when that temporary is dropped and runs the destructor for type `std::result::Result<MutexGuard<'_>, ()>` | help: consider adding semicolon after the expression so its temporaries are dropped sooner, before the local variables declared by the block are dropped | LL | if let Ok(_) = counter.lock() { }; | ^ ```
2020-04-16 19:43:40 +00:00
= note: the temporary is part of an expression at the end of a block;
consider forcing this temporary to be dropped sooner, before the block's local variables are dropped
help: for example, you could save the expression's value in a new local variable `x` and then make `x` be the expression at the end of the block
|
LL | let x = y.borrow().clone(); x
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-22 02:07:19 +00:00
| +++++++ +++
improve "Doesn't live long enough" error
2016-10-14 15:55:45 +00:00
Revert "Change error count messages" This reverts commit 5558c64f33446225739c1153b43d2e309bb4f50e.
2017-07-02 10:49:30 +00:00
error: aborting due to 2 previous errors
improve "Doesn't live long enough" error
2016-10-14 15:55:45 +00:00
update tests
2018-03-03 14:59:40 +00:00
For more information about this error, try `rustc --explain E0597`.
Reference in a new issue Copy permalink