Use root obligation on E0277 for some cases
When encountering trait bound errors that satisfy some heuristics that
tell us that the relevant trait for the user comes from the root
obligation and not the current obligation, we use the root predicate for
the main message.
This allows to talk about "X doesn't implement Pattern<'_>" over the
most specific case that just happened to fail, like "char doesn't
implement Fn(&mut char)" in
`tests/ui/traits/suggest-dereferences/root-obligation.rs`
The heuristics are:
- the type of the leaf predicate is (roughly) the same as the type
from the root predicate, as a proxy for "we care about the root"
- the leaf trait and the root trait are different, so as to avoid
talking about `&mut T: Trait` and instead remain talking about
`T: Trait` instead
- the root trait is not `Unsize`, as to avoid talking about it in
`tests/ui/coercion/coerce-issue-49593-box-never.rs`.
```
error[E0277]: the trait bound `&char: Pattern<'_>` is not satisfied
--> $DIR/root-obligation.rs:6:38
|
LL | .filter(|c| "aeiou".contains(c))
| -------- ^ the trait `Fn<(char,)>` is not implemented for `&char`, which is required by `&char: Pattern<'_>`
| |
| required by a bound introduced by this call
|
= note: required for `&char` to implement `FnOnce<(char,)>`
= note: required for `&char` to implement `Pattern<'_>`
note: required by a bound in `core::str::<impl str>::contains`
--> $SRC_DIR/core/src/str/mod.rs:LL:COL
help: consider dereferencing here
|
LL | .filter(|c| "aeiou".contains(*c))
| +
```
Fix #79359, fix #119983, fix #118779, cc #118415 (the suggestion needs
to change).
2024-02-29 00:35:59 +00:00
error[E0277]: the trait bound `Box<{integer}>: Foo` is not satisfied
2019-01-08 21:14:04 +00:00
--> $DIR/kindck-inherited-copy-bound.rs:21:16
2018-08-08 12:28:26 +00:00
|
2019-03-09 12:03:44 +00:00
LL | take_param(&x);
2024-01-29 18:31:02 +00:00
| ---------- ^^ the trait `Copy` is not implemented for `Box<{integer}>`, which is required by `Box<{integer}>: Foo`
2021-09-07 11:30:53 +00:00
| |
| required by a bound introduced by this call
2018-08-08 12:28:26 +00:00
|
2022-08-15 20:31:37 +00:00
note: required for `Box<{integer}>` to implement `Foo`
2021-03-30 20:37:30 +00:00
--> $DIR/kindck-inherited-copy-bound.rs:14:14
|
LL | impl<T:Copy> Foo for T {
2023-01-11 03:21:11 +00:00
| ---- ^^^ ^
| |
| unsatisfied trait bound introduced here
2021-07-31 16:26:55 +00:00
note: required by a bound in `take_param`
--> $DIR/kindck-inherited-copy-bound.rs:17:17
|
LL | fn take_param<T:Foo>(foo: &T) { }
| ^^^ required by this bound in `take_param`
2018-08-08 12:28:26 +00:00
error[E0038]: the trait `Foo` cannot be made into an object
2019-01-08 21:14:04 +00:00
--> $DIR/kindck-inherited-copy-bound.rs:28:19
2018-08-08 12:28:26 +00:00
|
2020-10-16 00:23:45 +00:00
LL | let z = &x as &dyn Foo;
2020-10-20 00:57:18 +00:00
| ^^^^^^^^ `Foo` cannot be made into an object
2020-10-16 00:23:45 +00:00
|
note: for a trait to be "object safe" it needs to allow building a vtable to allow the call to be resolvable dynamically; for more information visit <https://doc.rust-lang.org/reference/items/traits.html#object-safety>
--> $DIR/kindck-inherited-copy-bound.rs:10:13
|
2020-01-29 20:59:04 +00:00
LL | trait Foo : Copy {
2020-10-16 00:23:45 +00:00
| --- ^^^^ ...because it requires `Self: Sized`
2020-02-01 00:47:00 +00:00
| |
| this trait cannot be made into an object...
2018-08-08 12:28:26 +00:00
error[E0038]: the trait `Foo` cannot be made into an object
2019-01-08 21:14:04 +00:00
--> $DIR/kindck-inherited-copy-bound.rs:28:13
2018-08-08 12:28:26 +00:00
|
2019-05-28 18:46:13 +00:00
LL | let z = &x as &dyn Foo;
2020-10-20 00:57:18 +00:00
| ^^ `Foo` cannot be made into an object
2018-08-08 12:28:26 +00:00
|
2020-10-16 00:23:45 +00:00
note: for a trait to be "object safe" it needs to allow building a vtable to allow the call to be resolvable dynamically; for more information visit <https://doc.rust-lang.org/reference/items/traits.html#object-safety>
--> $DIR/kindck-inherited-copy-bound.rs:10:13
|
LL | trait Foo : Copy {
| --- ^^^^ ...because it requires `Self: Sized`
| |
| this trait cannot be made into an object...
2023-05-11 02:10:56 +00:00
= note: required for the cast from `&Box<{integer}>` to `&dyn Foo`
2018-08-08 12:28:26 +00:00
error: aborting due to 3 previous errors
2019-04-17 17:26:38 +00:00
Some errors have detailed explanations: E0038, E0277.
2018-08-08 12:28:26 +00:00
For more information about an error, try `rustc --explain E0038`.
