2019-07-02 21:30:28 +00:00
|
|
|
//@ build-pass (FIXME(62277): could be check-pass?)
|
2019-06-08 14:42:58 +00:00
|
|
|
|
2019-06-08 08:36:43 +00:00
|
|
|
#![feature(rustc_attrs)]
|
2018-08-31 13:02:01 +00:00
|
|
|
|
2019-06-08 08:36:43 +00:00
|
|
|
struct Cat {
|
|
|
|
|
name: String,
|
2012-11-14 06:22:37 +00:00
|
|
|
}
|
|
|
|
|
|
2019-06-08 08:36:43 +00:00
|
|
|
impl Drop for Cat {
|
|
|
|
|
#[rustc_dummy]
|
2012-11-14 06:22:37 +00:00
|
|
|
/**
|
|
|
|
|
Actually, cats don't always land on their feet when you drop them.
|
|
|
|
|
*/
|
2013-09-17 01:18:07 +00:00
|
|
|
fn drop(&mut self) {
|
log: Introduce liblog, the old std::logging
This commit moves all logging out of the standard library into an external
crate. This crate is the new crate which is responsible for all logging macros
and logging implementation. A few reasons for this change are:
* The crate map has always been a bit of a code smell among rust programs. It
has difficulty being loaded on almost all platforms, and it's used almost
exclusively for logging and only logging. Removing the crate map is one of the
end goals of this movement.
* The compiler has a fair bit of special support for logging. It has the
__log_level() expression as well as generating a global word per module
specifying the log level. This is unfairly favoring the built-in logging
system, and is much better done purely in libraries instead of the compiler
itself.
* Initialization of logging is much easier to do if there is no reliance on a
magical crate map being available to set module log levels.
* If the logging library can be written outside of the standard library, there's
no reason that it shouldn't be. It's likely that we're not going to build the
highest quality logging library of all time, so third-party libraries should
be able to provide just as high-quality logging systems as the default one
provided in the rust distribution.
With a migration such as this, the change does not come for free. There are some
subtle changes in the behavior of liblog vs the previous logging macros:
* The core change of this migration is that there is no longer a physical
log-level per module. This concept is still emulated (it is quite useful), but
there is now only a global log level, not a local one. This global log level
is a reflection of the maximum of all log levels specified. The previously
generated logging code looked like:
if specified_level <= __module_log_level() {
println!(...)
}
The newly generated code looks like:
if specified_level <= ::log::LOG_LEVEL {
if ::log::module_enabled(module_path!()) {
println!(...)
}
}
Notably, the first layer of checking is still intended to be "super fast" in
that it's just a load of a global word and a compare. The second layer of
checking is executed to determine if the current module does indeed have
logging turned on.
This means that if any module has a debug log level turned on, all modules
with debug log levels get a little bit slower (they all do more expensive
dynamic checks to determine if they're turned on or not).
Semantically, this migration brings no change in this respect, but
runtime-wise, this will have a perf impact on some code.
* A `RUST_LOG=::help` directive will no longer print out a list of all modules
that can be logged. This is because the crate map will no longer specify the
log levels of all modules, so the list of modules is not known. Additionally,
warnings can no longer be provided if a malformed logging directive was
supplied.
The new "hello world" for logging looks like:
#[phase(syntax, link)]
extern crate log;
fn main() {
debug!("Hello, world!");
}
2014-03-09 06:11:44 +00:00
|
|
|
println!("{} landed on hir feet", self.name);
|
2012-11-14 06:22:37 +00:00
|
|
|
}
|
2012-07-17 02:16:19 +00:00
|
|
|
}
|
|
|
|
|
|
2019-06-08 08:36:43 +00:00
|
|
|
#[rustc_dummy]
|
2012-09-05 22:58:43 +00:00
|
|
|
/**
|
|
|
|
|
Maybe it should technically be a kitten_maker.
|
|
|
|
|
*/
|
2019-06-08 08:36:43 +00:00
|
|
|
fn cat(name: String) -> Cat {
|
|
|
|
|
Cat {
|
2012-09-05 22:58:43 +00:00
|
|
|
name: name
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-06-08 08:36:43 +00:00
|
|
|
fn main() {
|
|
|
|
|
let _kitty = cat("Spotty".to_string());
|
2012-07-17 02:16:19 +00:00
|
|
|
}
|