mirror of
https://github.com/golang/go
synced 2024-09-05 16:04:50 +00:00
![David Chase](/assets/img/avatar_default.png)
Try to provide hints for common areas, either *interface were interface would have been better, and note incorrect capitalization (but don't be more ambitious than that, at least not today). Added code and test for cases ptrInterface.ExistingMethod ptrInterface.unexportedMethod ptrInterface.MissingMethod ptrInterface.withwRongcASEdMethod interface.withwRongcASEdMethod ptrStruct.withwRongcASEdMethod struct.withwRongcASEdMethod also included tests for related errors to check for unintentional changes and consistent wording. Somewhat simplified from previous versions to avoid second- guessing user errors, yet also biased to point out most-likely root cause. Fixes #10700 Change-Id: I16693e93cc8d8ca195e7742a222d640c262105b4 Reviewed-on: https://go-review.googlesource.com/9731 Reviewed-by: Russ Cox <rsc@golang.org>
76 lines
1.4 KiB
Go
76 lines
1.4 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test methods derived from embedded interface and *interface values.
|
|
|
|
package main
|
|
|
|
import "os"
|
|
|
|
const Value = 1e12
|
|
|
|
type Inter interface {
|
|
M() int64
|
|
}
|
|
|
|
type T int64
|
|
|
|
func (t T) M() int64 { return int64(t) }
|
|
|
|
var t = T(Value)
|
|
var pt = &t
|
|
var ti Inter = t
|
|
var pti = &ti
|
|
|
|
type S struct{ Inter }
|
|
|
|
var s = S{ti}
|
|
var ps = &s
|
|
|
|
type SP struct{ *Inter } // ERROR "interface"
|
|
|
|
var i Inter
|
|
var pi = &i
|
|
|
|
var ok = true
|
|
|
|
func check(s string, v int64) {
|
|
if v != Value {
|
|
println(s, v)
|
|
ok = false
|
|
}
|
|
}
|
|
|
|
func main() {
|
|
check("t.M()", t.M())
|
|
check("pt.M()", pt.M())
|
|
check("ti.M()", ti.M())
|
|
check("pti.M()", pti.M()) // ERROR "pointer to interface, not interface"
|
|
check("s.M()", s.M())
|
|
check("ps.M()", ps.M())
|
|
|
|
i = t
|
|
check("i = t; i.M()", i.M())
|
|
check("i = t; pi.M()", pi.M()) // ERROR "pointer to interface, not interface"
|
|
|
|
i = pt
|
|
check("i = pt; i.M()", i.M())
|
|
check("i = pt; pi.M()", pi.M()) // ERROR "pointer to interface, not interface"
|
|
|
|
i = s
|
|
check("i = s; i.M()", i.M())
|
|
check("i = s; pi.M()", pi.M()) // ERROR "pointer to interface, not interface"
|
|
|
|
i = ps
|
|
check("i = ps; i.M()", i.M())
|
|
check("i = ps; pi.M()", pi.M()) // ERROR "pointer to interface, not interface"
|
|
|
|
if !ok {
|
|
println("BUG: interface10")
|
|
os.Exit(1)
|
|
}
|
|
}
|