mirror of
https://github.com/golang/go
synced 2024-09-04 23:44:16 +00:00
![Dan Scales](/assets/img/avatar_default.png)
Enable a bunch of types2-related error tests to run successfully, so they no longer have to be disabled in run.go. - directive.go: split it into directive.go and directive2.go, since the possible errors are now split across the parser and noder2, so they can't all be reported in one file. - linkname2.go: similarly, split it into linkname2.go and linkname3.go for the same reason. - issue16428.go, issue17645.go, issue47201.dir/bo.go: handle slightly different wording by types2 - issue5609.go: handle slight different error (array length must be integer vs. array bound too large). - float_lit3.go: handle slightly different wording (overflows float vs cannot convert to float) I purposely didn't try to fix tests yet where there are extra or missing errors on different lines, since that is not easy to make work for both -G=3 and -G=0. In a later change, will flip to make the types2 version match correctly, vs. the -G=0 version. Change-Id: I6079ff258e3b90146335b9995764e3b1b56cda59 Reviewed-on: https://go-review.googlesource.com/c/go/+/368455 Trust: Dan Scales <danscales@google.com> Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
48 lines
1.7 KiB
Go
48 lines
1.7 KiB
Go
// errorcheck
|
|
|
|
// Check flagging of invalid conversion of constant to float32/float64 near min/max boundaries.
|
|
|
|
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
// See float_lit2.go for motivation for these values.
|
|
const (
|
|
two24 = 1.0 * (1 << 24)
|
|
two53 = 1.0 * (1 << 53)
|
|
two64 = 1.0 * (1 << 64)
|
|
two128 = two64 * two64
|
|
two256 = two128 * two128
|
|
two512 = two256 * two256
|
|
two768 = two512 * two256
|
|
two1024 = two512 * two512
|
|
|
|
ulp32 = two128 / two24
|
|
max32 = two128 - ulp32
|
|
|
|
ulp64 = two1024 / two53
|
|
max64 = two1024 - ulp64
|
|
)
|
|
|
|
var x = []interface{}{
|
|
float32(max32 + ulp32/2 - 1), // ok
|
|
float32(max32 + ulp32/2 - two128/two256), // ok
|
|
float32(max32 + ulp32/2), // ERROR "constant 3\.40282e\+38 overflows float32|cannot convert.*to type float32"
|
|
|
|
float32(-max32 - ulp32/2 + 1), // ok
|
|
float32(-max32 - ulp32/2 + two128/two256), // ok
|
|
float32(-max32 - ulp32/2), // ERROR "constant -3\.40282e\+38 overflows float32|cannot convert.*to type float32"
|
|
|
|
// If the compiler's internal floating point representation
|
|
// is shorter than 1024 bits, it cannot distinguish max64+ulp64/2-1 and max64+ulp64/2.
|
|
float64(max64 + ulp64/2 - two1024/two256), // ok
|
|
float64(max64 + ulp64/2 - 1), // ok
|
|
float64(max64 + ulp64/2), // ERROR "constant 1\.79769e\+308 overflows float64|cannot convert.*to type float64"
|
|
|
|
float64(-max64 - ulp64/2 + two1024/two256), // ok
|
|
float64(-max64 - ulp64/2 + 1), // ok
|
|
float64(-max64 - ulp64/2), // ERROR "constant -1\.79769e\+308 overflows float64|cannot convert.*to type float64"
|
|
}
|