mirror of
https://github.com/golang/go
synced 2024-09-04 23:44:16 +00:00
![Joel Sing](/assets/img/avatar_default.png)
Open-coded defers were fixed and re-enabled on riscv64, however this test was inadvertantly left disabled. Updates #36786 Change-Id: I128fc84baa3d51f50d173e19e52051dc4d9a07c3 Reviewed-on: https://go-review.googlesource.com/c/go/+/220920 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
87 lines
1.4 KiB
Go
87 lines
1.4 KiB
Go
// errorcheck -0 -l -d=defer
|
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// check that open-coded defers are used in expected situations
|
|
|
|
package main
|
|
|
|
import "fmt"
|
|
|
|
var glob = 3
|
|
|
|
func f1() {
|
|
|
|
for i := 0; i < 10; i++ {
|
|
fmt.Println("loop")
|
|
}
|
|
defer func() { // ERROR "open-coded defer"
|
|
fmt.Println("defer")
|
|
}()
|
|
}
|
|
|
|
func f2() {
|
|
for {
|
|
defer func() { // ERROR "heap-allocated defer"
|
|
fmt.Println("defer1")
|
|
}()
|
|
if glob > 2 {
|
|
break
|
|
}
|
|
}
|
|
defer func() { // ERROR "stack-allocated defer"
|
|
fmt.Println("defer2")
|
|
}()
|
|
}
|
|
|
|
func f3() {
|
|
defer func() { // ERROR "stack-allocated defer"
|
|
fmt.Println("defer2")
|
|
}()
|
|
for {
|
|
defer func() { // ERROR "heap-allocated defer"
|
|
fmt.Println("defer1")
|
|
}()
|
|
if glob > 2 {
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
func f4() {
|
|
defer func() { // ERROR "open-coded defer"
|
|
fmt.Println("defer")
|
|
}()
|
|
label:
|
|
fmt.Println("goto loop")
|
|
if glob > 2 {
|
|
goto label
|
|
}
|
|
}
|
|
|
|
func f5() {
|
|
label:
|
|
fmt.Println("goto loop")
|
|
defer func() { // ERROR "heap-allocated defer"
|
|
fmt.Println("defer")
|
|
}()
|
|
if glob > 2 {
|
|
goto label
|
|
}
|
|
}
|
|
|
|
func f6() {
|
|
label:
|
|
fmt.Println("goto loop")
|
|
if glob > 2 {
|
|
goto label
|
|
}
|
|
// The current analysis doesn't end a backward goto loop, so this defer is
|
|
// considered to be inside a loop
|
|
defer func() { // ERROR "heap-allocated defer"
|
|
fmt.Println("defer")
|
|
}()
|
|
}
|