dad2966a83
Add a new flag 'paramNames' to typeWriter struct to control whether function parameter names are written or not (set by default). Unset it when we want the function signature w/o parameter names, e.g. when showing two signatures that are not identical. This makes is much easier to see the typw differences in the error message. To avoid needing to provide yet another (rarely used) boolean parameter to typeString, remove that function in favor of setting the paramNames flag explicitly. Adjust the code in errors.go that used typeString; the resulting code is also more efficient (fewer bytes.Buffer allocations). While at it, rename the typeWriter 'debug' field to 'tpSubscripts' because that is what it controls. Add test case and adjusted existing expected output for existing tests. Fixes #54942. Change-Id: I625eae30c403c39ce89951b8ea6214d783c92c75 Reviewed-on: https://go-review.googlesource.com/c/go/+/430416 Reviewed-by: Robert Findley <rfindley@google.com> Run-TryBot: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Robert Griesemer <gri@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.