mirror of
https://github.com/golang/go
synced 2024-07-08 12:18:55 +00:00
b3bd7ab3d7
The logic for keeping arguments alive for calls to //go:uintptrescapes functions was only applying to direct function calls. This CL changes it to also apply to direct method calls, which should address most uses of Proc.Call and LazyProc.Call. It's still an open question (#34684) whether other call forms (e.g., method expressions, or indirect calls via function values, method values, or interfaces). Fixes #34474. Change-Id: I874f97145972b0e237a4c9e8926156298f4d6ce0 Reviewed-on: https://go-review.googlesource.com/c/go/+/198043 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
66 lines
2.2 KiB
Go
66 lines
2.2 KiB
Go
// errorcheck -0 -l -m -live
|
|
|
|
// Copyright 2016 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis and liveness inferred for uintptrescapes functions.
|
|
|
|
package p
|
|
|
|
import (
|
|
"unsafe"
|
|
)
|
|
|
|
//go:uintptrescapes
|
|
func F1(a uintptr) {} // ERROR "escaping uintptr"
|
|
|
|
//go:uintptrescapes
|
|
func F2(a ...uintptr) {} // ERROR "escaping ...uintptr"
|
|
|
|
//go:uintptrescapes
|
|
func F3(uintptr) {} // ERROR "escaping uintptr"
|
|
|
|
//go:uintptrescapes
|
|
func F4(...uintptr) {} // ERROR "escaping ...uintptr"
|
|
|
|
type T struct{}
|
|
|
|
//go:uintptrescapes
|
|
func (T) M1(a uintptr) {} // ERROR "escaping uintptr"
|
|
|
|
//go:uintptrescapes
|
|
func (T) M2(a ...uintptr) {} // ERROR "escaping ...uintptr" "leaking param: a"
|
|
|
|
func TestF1() {
|
|
var t int // ERROR "moved to heap"
|
|
F1(uintptr(unsafe.Pointer(&t))) // ERROR "live at call to F1: .?autotmp" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestF3() {
|
|
var t2 int // ERROR "moved to heap"
|
|
F3(uintptr(unsafe.Pointer(&t2))) // ERROR "live at call to F3: .?autotmp" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestM1() {
|
|
var t T
|
|
var v int // ERROR "moved to heap"
|
|
t.M1(uintptr(unsafe.Pointer(&v))) // ERROR "live at call to T.M1: .?autotmp" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestF2() {
|
|
var v int // ERROR "moved to heap"
|
|
F2(0, 1, uintptr(unsafe.Pointer(&v)), 2) // ERROR "live at call to newobject: .?autotmp" "live at call to F2: .?autotmp" "escapes to heap" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestF4() {
|
|
var v2 int // ERROR "moved to heap"
|
|
F4(0, 1, uintptr(unsafe.Pointer(&v2)), 2) // ERROR "live at call to newobject: .?autotmp" "live at call to F4: .?autotmp" "escapes to heap" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|
|
|
|
func TestM2() {
|
|
var t T
|
|
var v int // ERROR "moved to heap"
|
|
t.M2(0, 1, uintptr(unsafe.Pointer(&v)), 2) // ERROR "live at call to newobject: .?autotmp" "live at call to T.M2: .?autotmp" "escapes to heap" "stack object .autotmp_[0-9]+ unsafe.Pointer$"
|
|
}
|