mirror of
https://github.com/golang/go
synced 2024-09-05 16:04:50 +00:00
![Cherry Zhang](/assets/img/avatar_default.png)
CL 35261 introduces special handling of zero-valued STRUCTLIT for efficient struct zeroing. But it didn't cover all use cases, for example, CONVNOP STRUCTLIT is not handled. On the other hand, CL 34566 handles zeroing earlier, so we don't need the change in CL 35261 for efficient zeroing. Other uses of zero-valued struct literals are very rare. So undo the change in walk.go in CL 35261. Add a test for efficient zeroing. Fixes #19084. Change-Id: I0807f7423fb44d47bf325b3c1ce9611a14953853 Reviewed-on: https://go-review.googlesource.com/36955 Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Keith Randall <khr@golang.org>
18 lines
330 B
Go
18 lines
330 B
Go
// compile
|
|
|
|
// Copyright 2017 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Issue 19084: SSA doesn't handle CONVNOP STRUCTLIT
|
|
|
|
package p
|
|
|
|
type T struct {
|
|
a, b, c, d, e, f, g, h int // big, not SSA-able
|
|
}
|
|
|
|
func f() {
|
|
_ = T(T{})
|
|
}
|