Ian Lance Taylor a16954b8a7 cmd/cgo: always use a function literal for pointer checking ... The pointer checking code needs to know the exact type of the parameter expected by the C function, so that it can use a type assertion to convert the empty interface returned by cgoCheckPointer to the correct type. Previously this was done by using a type conversion, but that meant that the code accepted arguments that were convertible to the parameter type, rather than arguments that were assignable as in a normal function call. In other words, some code that should not have passed type checking was accepted. This CL changes cgo to always use a function literal for pointer checking. Now the argument is passed to the function literal, which has the correct argument type, so type checking is performed just as for a function call as it should be. Since we now always use a function literal, simplify the checking code to run as a statement by itself. It now no longer needs to return a value, and we no longer need a type assertion. This does have the cost of introducing another function call into any call to a C function that requires pointer checking, but the cost of the additional call should be minimal compared to the cost of pointer checking. Fixes #16591. Change-Id: I220165564cf69db9fd5f746532d7f977a5b2c989 Reviewed-on: https://go-review.googlesource.com/31233 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>		2016-10-19 21:20:50 +00:00
..
android	misc/android: make the exec wrapper exit code parsing more robust	2016-06-08 05:24:53 +00:00
arm
cgo	cmd/cgo: always use a function literal for pointer checking	2016-10-19 21:20:50 +00:00
chrome/gophertool
git
ios
linkcheck
nacl	cmd/dist: use debug/pe directly for cmd/link	2016-10-17 15:22:17 +00:00
sortac
swig
trace	misc/trace: disable trace resolution warning	2016-07-21 18:17:31 +00:00
benchcmp
editors