96999296e6
After review, the only non-superficial change was to delegate the call to under(...) to structuralType. Otherwise, update a few stale comments: + correct indices in the documentation for tparamsList + update smap->substMap in a few places + update type parameter syntax in a couple places I've spent a good amount of time reviewing this code, and it fundamentally LGTM (though I wish we didn't have to copy the logic from identical0). However, as demonstrated in #43056, this code is complicated and not always easy to reason about, particularly in the context of type checking where not all types may be complete. To further understand and verify this code I'd like to write more tests, but that must wait until the rest of the changes in go/types are imported from dev.go2go. Change-Id: Iabb9d3a6af988a2e1b3445cde6bc2431a80f8bfe Reviewed-on: https://go-review.googlesource.com/c/go/+/276692 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Robert Findley <rfindley@google.com> Reviewed-by: Robert Griesemer <gri@golang.org> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
favicon.ico | ||
LICENSE | ||
PATENTS | ||
README.md | ||
robots.txt | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.