mirror of
https://github.com/golang/go
synced 2024-09-05 16:04:50 +00:00
![Dan Scales](/assets/img/avatar_default.png)
Enable a bunch of types2-related error tests to run successfully, so they no longer have to be disabled in run.go. - directive.go: split it into directive.go and directive2.go, since the possible errors are now split across the parser and noder2, so they can't all be reported in one file. - linkname2.go: similarly, split it into linkname2.go and linkname3.go for the same reason. - issue16428.go, issue17645.go, issue47201.dir/bo.go: handle slightly different wording by types2 - issue5609.go: handle slight different error (array length must be integer vs. array bound too large). - float_lit3.go: handle slightly different wording (overflows float vs cannot convert to float) I purposely didn't try to fix tests yet where there are extra or missing errors on different lines, since that is not easy to make work for both -G=3 and -G=0. In a later change, will flip to make the types2 version match correctly, vs. the -G=0 version. Change-Id: I6079ff258e3b90146335b9995764e3b1b56cda59 Reviewed-on: https://go-review.googlesource.com/c/go/+/368455 Trust: Dan Scales <danscales@google.com> Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
64 lines
1.2 KiB
Go
64 lines
1.2 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Verify that misplaced directives are diagnosed.
|
|
|
|
// ok
|
|
//go:build !ignore
|
|
|
|
package main
|
|
|
|
//go:build bad // ERROR "misplaced compiler directive"
|
|
|
|
//go:notinheap // ERROR "misplaced compiler directive"
|
|
type (
|
|
T2 int //go:notinheap // ERROR "misplaced compiler directive"
|
|
T2b int
|
|
T2c int
|
|
T3 int
|
|
)
|
|
|
|
//go:notinheap // ERROR "misplaced compiler directive"
|
|
type (
|
|
//go:notinheap
|
|
T4 int
|
|
)
|
|
|
|
//go:notinheap // ERROR "misplaced compiler directive"
|
|
type ()
|
|
|
|
type T5 int
|
|
|
|
func g() {} //go:noinline // ERROR "misplaced compiler directive"
|
|
|
|
// ok: attached to f (duplicated yes, but ok)
|
|
//go:noinline
|
|
|
|
//go:noinline
|
|
func f() {
|
|
//go:noinline // ERROR "misplaced compiler directive"
|
|
x := 1
|
|
|
|
//go:noinline // ERROR "misplaced compiler directive"
|
|
{
|
|
_ = x //go:noinline // ERROR "misplaced compiler directive"
|
|
}
|
|
var y int //go:noinline // ERROR "misplaced compiler directive"
|
|
//go:noinline // ERROR "misplaced compiler directive"
|
|
_ = y
|
|
|
|
const c = 1
|
|
|
|
_ = func() {}
|
|
|
|
// ok:
|
|
//go:notinheap
|
|
type T int
|
|
}
|
|
|
|
// EOF
|
|
//go:noinline // ERROR "misplaced compiler directive"
|