6d5c9f2f26
When reviewing https://go-review.googlesource.com/c/go/+/522435, Cherry Mui cherryyz@google.com noticed that the implementation of StructOf was broken, and produced junk if an interface was embedded into a struct. For example, StructOf messed up the calling convention for methods of the embedded interface: > The main problem is that the method wrappers created by reflect.MakeFunc > expects to be called with a closure calling convention, with a closure > context passed in the context register. But methods are called with > a different calling convention, without setting the closure register, > because (besides this case) all methods are top level functions. > So there is no way to pass that makefunc closure context. It is curious that StructOf did not break in go 1.17 which introduced the regabi. I've tried to run the following example program, and it fails even in 1.7 which introduced StructOf. As the embedding of interfaces has been broken since forever, let us not perpetuate the complexity that this feature brings, and just remove the support for embedding altogether. The test program: package main import ( "fmt" "reflect" ) type I interface { F() } type T int func (t T) F() { println(t) } func main() { var i I t := reflect.StructOf([]reflect.StructField{ { Anonymous: true, Name: "I", Type: reflect.TypeOf(&i).Elem(), }, }) v := reflect.New(t).Elem() v.Field(0).Set(reflect.ValueOf(T(42))) fmt.Println(v) v.Interface().(interface{ F() }).F() // fatal error } Change-Id: I7b2115c22d66ea4ed746f0f9d22b2c94f604e185 Reviewed-on: https://go-review.googlesource.com/c/go/+/526075 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.