mirror of
https://github.com/golang/go
synced 2024-09-05 16:04:50 +00:00
684332f47c
copyau1 was assuming that it could deduce the type of the middle register p->reg from the type of the left or right argument: in CMPF F1, F2, the p->reg==2 must be a D_FREG because p->from is F1, and in CMP R1, R2, the p->reg==2 must be a D_REG because p->from is R1. This heuristic fails for CMP $0, R2, which was causing copyau1 not to recognize p->reg==2 as a reference to R2, which was keeping it from properly renaming the register use when substituting registers. cmd/5c has the right approach: look at the opcode p->as to decide the kind of register. It is unclear where 5g's copyau1 came from; perhaps it was an attempt to avoid expanding 5c's a2type to include new instructions used only by 5g. Copy a2type from cmd/5c, expand to include additional instructions, and make it crash the compiler if asked about an instruction it does not understand (avoid silent bugs in the future if new instructions are added). Should fix current arm build breakage. While we're here, fix the print statements dumping the pred and succ info in the asm listing to pass an int arg to %.4ud (Prog.pc is a vlong now, due to the liblink merge). TBR=ken2 CC=golang-codereviews https://golang.org/cl/62730043 |
||
|---|---|---|
| api | ||
| doc | ||
| include | ||
| lib | ||
| misc | ||
| src | ||
| test | ||
| .hgignore | ||
| .hgtags | ||
| AUTHORS | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README | ||
| robots.txt | ||
This is the source code repository for the Go programming language.
For documentation about how to install and use Go,
visit http://golang.org/ or load doc/install-source.html
in your web browser.
After installing Go, you can view a nicely formatted
doc/install-source.html by running godoc --http=:6060
and then visiting http://localhost:6060/doc/install/source.
Unless otherwise noted, the Go source files are distributed
under the BSD-style license found in the LICENSE file.
--
Binary Distribution Notes
If you have just untarred a binary Go distribution, you need to set
the environment variable $GOROOT to the full path of the go
directory (the one containing this README). You can omit the
variable if you unpack it into /usr/local/go, or if you rebuild
from sources by running all.bash (see doc/install.html).
You should also add the Go binary directory $GOROOT/bin
to your shell's path.
For example, if you extracted the tar file into $HOME/go, you might
put the following in your .profile:
export GOROOT=$HOME/go
export PATH=$PATH:$GOROOT/bin
See doc/install.html for more details.