mirror of
https://github.com/golang/go
synced 2024-09-18 15:32:18 +00:00
9f89edcd96
In general, a conversion to interface type may require values to be boxed, which in turn necessitates escape analysis to determine whether the boxed representation can be stack allocated. However, esc.go used to unconditionally print escape analysis decisions about OCONVIFACE, even for conversions that don't require boxing (e.g., pointers, channels, maps, functions). For test compatibility with esc.go, escape.go similarly printed these useless diagnostics. This CL removes the diagnostics, and updates test expectations accordingly. Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12 Reviewed-on: https://go-review.googlesource.com/c/go/+/192697 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
108 lines
2.8 KiB
Go
108 lines
2.8 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis for maps.
|
|
|
|
package escape
|
|
|
|
var sink interface{}
|
|
|
|
func map0() {
|
|
m := make(map[*int]*int) // ERROR "make\(map\[\*int\]\*int\) does not escape"
|
|
// BAD: i should not escape
|
|
i := 0 // ERROR "moved to heap: i"
|
|
// BAD: j should not escape
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m[&i] = &j
|
|
_ = m
|
|
}
|
|
|
|
func map1() *int {
|
|
m := make(map[*int]*int) // ERROR "make\(map\[\*int\]\*int\) does not escape"
|
|
// BAD: i should not escape
|
|
i := 0 // ERROR "moved to heap: i"
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m[&i] = &j
|
|
return m[&i]
|
|
}
|
|
|
|
func map2() map[*int]*int {
|
|
m := make(map[*int]*int) // ERROR "make\(map\[\*int\]\*int\) escapes to heap"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m[&i] = &j
|
|
return m
|
|
}
|
|
|
|
func map3() []*int {
|
|
m := make(map[*int]*int) // ERROR "make\(map\[\*int\]\*int\) does not escape"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
// BAD: j should not escape
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m[&i] = &j
|
|
var r []*int
|
|
for k := range m {
|
|
r = append(r, k)
|
|
}
|
|
return r
|
|
}
|
|
|
|
func map4() []*int {
|
|
m := make(map[*int]*int) // ERROR "make\(map\[\*int\]\*int\) does not escape"
|
|
// BAD: i should not escape
|
|
i := 0 // ERROR "moved to heap: i"
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m[&i] = &j
|
|
var r []*int
|
|
for k, v := range m {
|
|
// We want to test exactly "for k, v := range m" rather than "for _, v := range m".
|
|
// The following if is merely to use (but not leak) k.
|
|
if k != nil {
|
|
r = append(r, v)
|
|
}
|
|
}
|
|
return r
|
|
}
|
|
|
|
func map5(m map[*int]*int) { // ERROR "m does not escape"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m[&i] = &j
|
|
}
|
|
|
|
func map6(m map[*int]*int) { // ERROR "m does not escape"
|
|
if m != nil {
|
|
m = make(map[*int]*int) // ERROR "make\(map\[\*int\]\*int\) does not escape"
|
|
}
|
|
i := 0 // ERROR "moved to heap: i"
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m[&i] = &j
|
|
}
|
|
|
|
func map7() {
|
|
// BAD: i should not escape
|
|
i := 0 // ERROR "moved to heap: i"
|
|
// BAD: j should not escape
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m := map[*int]*int{&i: &j} // ERROR "literal does not escape"
|
|
_ = m
|
|
}
|
|
|
|
func map8() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m := map[*int]*int{&i: &j} // ERROR "literal escapes to heap"
|
|
sink = m
|
|
}
|
|
|
|
func map9() *int {
|
|
// BAD: i should not escape
|
|
i := 0 // ERROR "moved to heap: i"
|
|
j := 0 // ERROR "moved to heap: j"
|
|
m := map[*int]*int{&i: &j} // ERROR "literal does not escape"
|
|
return m[nil]
|
|
}
|