go/test/escape_runtime_atomic.go
Matthew Dempsky b5946ed48d test: fix escape_runtime_atomic.go
Casp1 is implemented in Go on js/wasm, so escape analysis correctly
determines that the "old" parameter does not escape (which is good).

Unfortunately, test/run.go doesn't have a way to indicate that ERROR
messages are optional, and cmd/compile only emits diagnostics for "var
x int" when it's moved to the heap; not when it stays on the stack.

To accomodate that this test currently passes on some GOARCHes but not
others, rewrite the Casp1 test to use "x := new(int)" and allow both
"new(int) escapes to heap" or "new(int) does not escape".

Updates #31525.

Change-Id: I40150a7ff9042f184386ccdb2d4d428f63e8ba4f
Reviewed-on: https://go-review.googlesource.com/c/go/+/172602
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-04-17 22:55:26 +00:00

33 lines
874 B
Go

// errorcheck -0 -m -l
// Copyright 2019 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Test escape analysis for runtime/internal/atomic.
package escape
import (
"runtime/internal/atomic"
"unsafe"
)
// BAD: should always be "leaking param: addr to result ~r1 level=1$".
func Loadp(addr unsafe.Pointer) unsafe.Pointer { // ERROR "leaking param: addr( to result ~r1 level=1)?$"
return atomic.Loadp(addr)
}
var ptr unsafe.Pointer
func Storep() {
var x int // ERROR "moved to heap: x"
atomic.StorepNoWB(unsafe.Pointer(&ptr), unsafe.Pointer(&x))
}
func Casp1() {
// BAD: should always be "does not escape"
x := new(int) // ERROR "escapes to heap|does not escape"
var y int // ERROR "moved to heap: y"
atomic.Casp1(&ptr, unsafe.Pointer(x), unsafe.Pointer(&y))
}