mirror of
https://github.com/golang/go
synced 2024-09-04 23:44:16 +00:00
![Cuong Manh Le](/assets/img/avatar_default.png)
This ports the fix in CL 328050 for typecheck to types2. The fix is not identical, due to code structure differences between typecheck and types2, but the idea is the same. We only do the untyped conversion when both operands can be mixed. Updates #46749 Change-Id: Ib2c63ba0d5dd8bf02318b1bfdfe51dcaeeeb7f82 Reviewed-on: https://go-review.googlesource.com/c/go/+/328053 Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
38 lines
1.4 KiB
Go
38 lines
1.4 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package p
|
|
|
|
var s string
|
|
var b bool
|
|
var i int
|
|
var iface interface{}
|
|
|
|
var (
|
|
_ = "" + b // ERROR "invalid operation.*mismatched types.*untyped string and bool"
|
|
_ = "" + i // ERROR "invalid operation.*mismatched types.*untyped string and int"
|
|
_ = "" + nil // ERROR "invalid operation.*mismatched types.*untyped string and nil|(untyped nil)"
|
|
)
|
|
|
|
var (
|
|
_ = s + false // ERROR "invalid operation.*mismatched types.*string and untyped bool"
|
|
_ = s + 1 // ERROR "invalid operation.*mismatched types.*string and untyped int"
|
|
_ = s + nil // ERROR "invalid operation.*mismatched types.*string and nil|(untyped nil)"
|
|
)
|
|
|
|
var (
|
|
_ = "" + false // ERROR "invalid operation.*mismatched types.*untyped string and untyped bool"
|
|
_ = "" + 1 // ERROR "invalid operation.*mismatched types.*untyped string and untyped int"
|
|
)
|
|
|
|
var (
|
|
_ = b + 1 // ERROR "invalid operation.*mismatched types.*bool and untyped int"
|
|
_ = i + false // ERROR "invalid operation.*mismatched types.*int and untyped bool"
|
|
_ = iface + 1 // ERROR "invalid operation.*mismatched types.*interface *{} and int"
|
|
_ = iface + 1.0 // ERROR "invalid operation.*mismatched types.*interface *{} and float64"
|
|
_ = iface + false // ERROR "invalid operation.*mismatched types.*interface *{} and bool"
|
|
)
|