mirror of
https://github.com/golang/go
synced 2024-09-04 23:44:16 +00:00
![Cuong Manh Le](/assets/img/avatar_default.png)
If any of the LHS expressions of an OAS2FUNC are not identical to the respective function call results, escape analysis mishandles the implicit conversion, causes memory corruption. Instead, we should insert autotmps like we already do for f(g()) calls and return g() statements. Fixes #46725 Change-Id: I71a08da0bf1a03d09a023da5b6f78fb37a4a4690 Reviewed-on: https://go-review.googlesource.com/c/go/+/327651 Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
49 lines
763 B
Go
49 lines
763 B
Go
// run
|
|
|
|
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import "runtime"
|
|
|
|
type T [4]int
|
|
|
|
//go:noinline
|
|
func g(x []*T) ([]*T, []*T) { return x, x }
|
|
|
|
func main() {
|
|
const Jenny = 8675309
|
|
s := [10]*T{{Jenny}}
|
|
|
|
done := make(chan struct{})
|
|
runtime.SetFinalizer(s[0], func(p *T) { close(done) })
|
|
|
|
var h, _ interface{} = g(s[:])
|
|
|
|
if wait(done) {
|
|
panic("GC'd early")
|
|
}
|
|
|
|
if h.([]*T)[0][0] != Jenny {
|
|
panic("lost Jenny's number")
|
|
}
|
|
|
|
if !wait(done) {
|
|
panic("never GC'd")
|
|
}
|
|
}
|
|
|
|
func wait(done <-chan struct{}) bool {
|
|
for i := 0; i < 10; i++ {
|
|
runtime.GC()
|
|
select {
|
|
case <-done:
|
|
return true
|
|
default:
|
|
}
|
|
}
|
|
return false
|
|
}
|