go/test/fixedbugs/issue19507.dir at 018b78cc5b4b08447076f143271c249c0dde1297 - languages/go

mirror of https://github.com/golang/go synced 2024-09-04 23:44:16 +00:00

History

Austin Clements a3c70e28ed test: fix ABI mismatch in fixedbugs/issue19507 Because run.go doesn't pass the package being compiled to the compiler via the -p flag, it can't match up the main·f symbol from the assembler with the "func f" stub in Go, so it doesn't produce the correct assembly stub. Fix this by removing the package prefix from the assembly definition. Alternatively, we could make run.go pass -p to the compiler, but it's nicer to remove these package prefixes anyway. Should fix the linux-arm builder, which was broken by the introduction of function ABIs in CL 147160. Updates #27539. Change-Id: Id62b7701e1108a21a5ad48ffdb5dad4356c273a6 Reviewed-on: https://go-review.googlesource.com/c/149483 Run-TryBot: Austin Clements <austin@google.com> Reviewed-by: Keith Randall <khr@golang.org>	2018-11-13 23:44:52 +00:00
..
div_arm.s	test: fix ABI mismatch in fixedbugs/issue19507	2018-11-13 23:44:52 +00:00
main.go

Austin Clements a3c70e28ed test: fix ABI mismatch in fixedbugs/issue19507

Because run.go doesn't pass the package being compiled to the compiler
via the -p flag, it can't match up the main·f symbol from the
assembler with the "func f" stub in Go, so it doesn't produce the
correct assembly stub.

Fix this by removing the package prefix from the assembly definition.

Alternatively, we could make run.go pass -p to the compiler, but it's
nicer to remove these package prefixes anyway.

Should fix the linux-arm builder, which was broken by the introduction
of function ABIs in CL 147160.

Updates #27539.

Change-Id: Id62b7701e1108a21a5ad48ffdb5dad4356c273a6
Reviewed-on: https://go-review.googlesource.com/c/149483
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Keith Randall <khr@golang.org>

2018-11-13 23:44:52 +00:00

div_arm.s

test: fix ABI mismatch in fixedbugs/issue19507

2018-11-13 23:44:52 +00:00

main.go