Commit graph

11953 commits

Author SHA1 Message Date
Rob Pike d3f9aa47e5 cmd/go: fix 'go help'
It depended on old behavior of functions in structs.
Solved by adding a boolean method to check .Run != nil.

R=golang-dev, adg, r, rsc
CC=golang-dev
https://golang.org/cl/5674062
2012-02-15 18:12:42 -08:00
Andrew Gerrand e9016bb8a7 go/ast: return Examples in name order
R=bradfitz
CC=golang-dev
https://golang.org/cl/5673061
2012-02-16 13:08:35 +11:00
Andrew Gerrand 7c9662f461 godoc: show example function doc comments in UI
R=gri
CC=golang-dev
https://golang.org/cl/5677061
2012-02-16 12:43:22 +11:00
Andrew Gerrand 11e113db57 godoc: make example code more readable with new comment convention
go/doc: move Examples to go/ast
cmd/go: use go/doc to read examples
src/pkg: update examples to use new convention

This is to make whole file examples more readable. When presented as a
complete function, preceding an Example with its output is confusing.
The new convention is to put the expected output in the final comment
of the example, preceded by the string "output:" (case insensitive).

An idiomatic example looks like this:

// This example demonstrates Foo by doing bar and quux.
func ExampleFoo() {
        // example body that does bar and quux

        // Output:
        // example output
}

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5673053
2012-02-16 11:50:28 +11:00
Alex Brainman fa0100cf26 make.bat: implement --no-clean
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5656070
2012-02-16 11:34:41 +11:00
Alex Brainman 034c72a557 build: use setlocal in run.bat
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5672061
2012-02-16 10:44:55 +11:00
Alex Brainman 32cb495b18 build: keep environment variable changes local during Windows build
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5673048
2012-02-16 10:26:01 +11:00
Rémy Oudompheng 79db6ada48 cmd/gc: error on constant shift overflows.
Fixes #3019.

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/5674044
2012-02-16 00:19:42 +01:00
Brad Fitzpatrick 88f8af127a bufio: don't return errors from good Peeks
Fixes #3022

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5674060
2012-02-16 10:15:36 +11:00
Brad Fitzpatrick 3a317183a1 net/http: add some examples
R=golang-dev, dsymonds, adg, rogpeppe, bradfitz
CC=golang-dev
https://golang.org/cl/5673052
2012-02-16 10:15:10 +11:00
Andrew Gerrand f3c3130685 godoc: support for package examples, display example suffixes
Fixes #2896.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5677047
2012-02-16 09:44:01 +11:00
Brad Fitzpatrick 9578839d60 net/http: fix race in sendfile test
Whoops. Consume the body of the first request
before making the subsequent /quit request.

R=golang-dev, untheoretic
CC=golang-dev
https://golang.org/cl/5674054
2012-02-16 09:27:26 +11:00
Robert Griesemer 47afa4dba5 go/printer: don't lose relevant parentheses when rewriting selector expressions
Also: Simplified handling of selector expressions. As a result, complicated
multi-line expressions containing selectors and calls/indices with arguments
broken accross lines don't get indented the same way as before, but the change
is minimal (see tests) and there's no such code in the std library. It seems
a worthwhile compromise given the much simpler code.

Applied gofmt -w $GOROOT/src $GOROOT/misc .

Fixes #1847.

R=rsc
CC=golang-dev
https://golang.org/cl/5675062
2012-02-15 12:25:37 -08:00
David du Colombier 1064f3a97b runtime: define NSIG to fix plan 9 build
R=rsc
CC=golang-dev
https://golang.org/cl/5677053
2012-02-15 14:36:20 -05:00
Russ Cox d531ea85b1 A+C: David du Colombier (individual CLA)
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5672055
2012-02-15 14:36:12 -05:00
Shenghou Ma 53d94a7220 cmd/go: suggest 'go test -i [args to test]'
Fixes #3023.

R=rsc
CC=golang-dev
https://golang.org/cl/5674055
2012-02-15 13:26:50 -05:00
Shenghou Ma 9c1f54c9ed cmd/go: go test -i correctly handle cgo packages
Previous CL (5674043) omit the case where runtime/cgo itself is out-of-date.
Fixes #2936 (again).

R=rsc
CC=golang-dev
https://golang.org/cl/5674048
2012-02-15 13:26:22 -05:00
Russ Cox 2506fd43d4 build: add make.bash --no-clean option
Makes it possible to run

GOARCH=amd64 make.bash
GOARCH=386 make.bash --no-clean

to avoid deleting some of the work done by the first one.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5673056
2012-02-15 11:48:17 -05:00
Ian Lance Taylor aef23cc49e test: add new test of indirect type references
Similar to bug190, but without recursive reference.  Crashed
gccgo.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5672053
2012-02-15 07:39:46 -08:00
Mikio Hara 0724e5cefe build: fix clean.bash
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5672052
2012-02-15 23:52:07 +09:00
Alex Brainman def2022bc0 cmd/dist: use correct package target when cross-compiling
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5672050
2012-02-15 09:02:45 -05:00
Shenghou Ma 6ed2b6c47d 5c, 6c, 8c, 6g, 8g: correct boundary checking
CL 5666043 fixed the same checking for 5g.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5666045
2012-02-15 08:59:03 -05:00
Brad Fitzpatrick 988968262d doc: fix links
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5671051
2012-02-15 00:59:01 -08:00
Albert Strasheim 571d6fc5e8 syscall: Make Pdeathsig type Signal in SysProcAttr on Linux.
R=rsc, iant, iant
CC=golang-dev
https://golang.org/cl/5656058
2012-02-14 21:31:20 -08:00
Nigel Tao 0c5239410e html/template: add Clone and AddParseTree. Make text/template's Clone
return (*Template, error), not just *Template.

Fixes #2757.

R=r
CC=golang-dev
https://golang.org/cl/5665044
2012-02-15 16:16:30 +11:00
Rob Pike aca8071fd5 text/template: evaluate function fields
Just an oversight they didn't work and easy to address.

Fixes #3025.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5656059
2012-02-15 16:05:34 +11:00
Alex Brainman 9a44560033 time: run TestTicker for longer during short test, otherwise it fails
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5671049
2012-02-15 14:56:47 +11:00
Andrew Gerrand 60797a375c tag weekly.2012-02-14
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5676046
2012-02-15 14:45:54 +11:00
Nigel Tao da8f037b57 fix: add fix for bufio, gzip, zlib NewWriterXxx changes.
Fixes #2979.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5664046
2012-02-15 14:41:47 +11:00
Yasuhiro Matsumoto 6fae34db94 cmd/dist: xprintf() can't output whole of 'dist env'.
R=golang-dev, mpimenov, alex.brainman
CC=golang-dev
https://golang.org/cl/5667045
2012-02-15 14:25:27 +11:00
Brad Fitzpatrick dabf3db715 os/exec: add some examples
R=golang-dev, adg, r, bradfitz
CC=golang-dev
https://golang.org/cl/5675054
2012-02-15 14:24:24 +11:00
Andrew Gerrand eccc22e542 doc: fix snapshot notes
R=bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/5675056
2012-02-15 14:20:21 +11:00
Andrew Gerrand d2f65a6461 weekly.2012-02-14
R=golang-dev, dsymonds, r, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5675055
2012-02-15 14:15:33 +11:00
Lai Jiangshan cc8e12bb52 reflect: fix panic strings
use ':' instead of ';' to keep consistency with the other panic strings

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5666048
2012-02-15 13:51:49 +11:00
Andrew Gerrand d6a3650ad7 strings: add Bernardo O'Higgins example
R=r, bradfitz
CC=golang-dev, rogpeppe
https://golang.org/cl/5673049
2012-02-15 13:38:28 +11:00
Lai Jiangshan 932cdfbc4c doc: fix codewalk/markov.go
When I build it, I got:
/home/njubee/work/golang/doc/codewalk/markov.go:124: undefined: time.Nanoseconds
time.Nanoseconds() does not exist now, use time.Now().UnixNano() instead

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5668044
2012-02-15 13:07:34 +11:00
Andrew Gerrand 4853cb9ab0 A+C: Lai Jiangshan
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5677046
2012-02-15 13:07:12 +11:00
Andrew Gerrand 3509687d6a doc: add playground.js
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5649087
2012-02-15 12:59:50 +11:00
Andrew Gerrand dd91d83d24 doc: add App Engine docs to 'learn' and 'reference' pages
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5672048
2012-02-15 12:58:40 +11:00
Brad Fitzpatrick 7127b6fddc bytes,strings: make *Reader implement io.ReaderAt
R=golang-dev, adg, bradfitz, r
CC=golang-dev
https://golang.org/cl/5675053
2012-02-15 12:58:00 +11:00
Gustavo Niemeyer b4d32d832f lib/godoc: fix subdirectories html reference
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5677043
2012-02-14 22:18:29 -02:00
Gustavo Niemeyer 8eee153bc8 runtime: fix grsec support
Changeset 36c9c7810f14 broke support for grsec-patched kernels.
Those do not give back the address requested without MAP_FIXED,
so when verifying an mmap without this flag for success, the
resulting address must not be compared against the requested
address since it may have succeeded at a different location.

R=golang-dev, rsc, gustavo, iant
CC=golang-dev
https://golang.org/cl/5650072
2012-02-14 22:09:02 -02:00
Brad Fitzpatrick 977e8d145b bytes: add Reader
copy of strings/reader{,_test}.go with
a few s/string/[]byte/

Fixes #2861

R=adg, rsc, r
CC=golang-dev
https://golang.org/cl/5666044
2012-02-15 11:06:16 +11:00
Brad Fitzpatrick c210ddfe2c net/http: make strace test more robust
Apparently some distros don't let you ptrace attach
to your own existing processes.

Run strace on the child directly, instead, which
reportedly is more often allowed, and makes the
code simpler too.

R=golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/5675050
2012-02-15 11:05:51 +11:00
Andrew Gerrand a50315304d doc: grey out line numbers
R=gri
CC=golang-dev
https://golang.org/cl/5675049
2012-02-15 10:31:28 +11:00
David Symonds 0ab3ea9738 build: create the correct $GOTOOLDIR.
Before this, make.bash --dist-tool would fail,
because $GOROOT/bin/tool was being mkdir'd
instead of $GOROOT/pkg/tool/linux_amd64.

R=rsc
CC=golang-dev
https://golang.org/cl/5666046
2012-02-15 09:06:24 +11:00
Robert Griesemer 3a582a768b godoc: make godoc go work
- if a package path leads to subdirectories only,
  show command instead, if any
- to force documentation for a command, use the
  cmd/ prefix, as in: godoc cmd/go
  (note that for the go command, the prefix is
  not required since there is no actual go library
  package at the moment)

Fixes #3012.

R=rsc
CC=golang-dev
https://golang.org/cl/5665049
2012-02-14 13:57:21 -08:00
David Symonds 95902d10d2 build: fix sudo.bash.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5647063
2012-02-15 08:42:16 +11:00
Russ Cox 9f333170bf cmd/go: a raft of fixes
* add -work option to save temporary files (Fixes issue 2980)
* fix go test -i to work with cgo packages (Fixes issue 2936)
* do not overwrite/remove empty directories or non-object
  files during build (Fixes issue 2829)
* remove package main vs package non-main heuristic:
  a directory must contain only one package (Fixes issue 2864)
* to make last item workable, ignore +build tags for files
  named on command line: go build x.go builds x.go even
  if it says // +build ignore.
* add // +build ignore tags to helper programs

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5674043
2012-02-14 16:39:20 -05:00
Maxim Pimenov 87a04c0bcf gc: fix comment in mkbuiltin
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5669046
2012-02-14 16:27:35 -05:00