languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-01 13:44:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/compile: fix wrong condition in tcShift

Browse source 
CL 279442 refactored typecheck arithmetic operators, but using wrong
condition for checking invalid rhs.

Updates #43311

Change-Id: I7a03a5535b82ac4ea4806725776b0a4f7af1b79a
Reviewed-on: https://go-review.googlesource.com/c/go/+/298714
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Cuong Manh Le 2021-03-04 22:27:41 +07:00
parent 9e6b1fcd0a
commit fbee173545
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/compile/internal/typecheck/expr.go
View file

@ -48,7 +48,7 @@ func tcAddr(n *ir.AddrExpr) ir.Node {
}
func tcShift(n, l, r ir.Node) (ir.Node, ir.Node, *types.Type) {
if l.Type() == nil || l.Type() == nil {
if l.Type() == nil || r.Type() == nil {
return l, r, nil
}

7
test/fixedbugs/bug297.go
View file

@ -1,4 +1,4 @@
// errorcheck
// errorcheck -d=panic
// Copyright 2010 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
@ -9,7 +9,8 @@
package main
type ByteSize float64
const (
_ = iota; // ignore first value by assigning to blank identifier
KB ByteSize = 1<<(10*X) // ERROR "undefined"
_ = iota // ignore first value by assigning to blank identifier
KB ByteSize = 1 << (10 * X) // ERROR "undefined"
)