languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-07-19 19:44:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cmd/cgo: ensure the command passed to run retains a trailing dash

Browse source 
This was accidentally broken by CL 127755.

Fixes #29333

Change-Id: I5e92048c64a55c1699d6c38eb4dbbd51c817b820
Reviewed-on: https://go-review.googlesource.com/c/155037
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Ian Lance Taylor 2018-12-19 07:03:04 -08:00
parent d902f23ec4
commit d9e2ba4fcc
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
misc/cgo/test/issue4339.go
View file

@ -5,7 +5,8 @@
package cgotest
/*
#include "issue4339.h"
// We've historically permitted #include <>, so test it here. Issue 29333.
#include <issue4339.h>
*/
import "C"

4
src/cmd/cgo/gcc.go
View file

@ -1992,8 +1992,10 @@ func (p *Package) gccErrors(stdin []byte) string {
}
}
// Force -O0 optimization
// Force -O0 optimization but keep the trailing "-" at the end.
nargs = append(nargs, "-O0")
nl := len(nargs)
nargs[nl-2], nargs[nl-1] = nargs[nl-1], nargs[nl-2]
if *debugGcc {
fmt.Fprintf(os.Stderr, "$ %s <<EOF\n", strings.Join(nargs, " "))