languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-14 20:05:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/godoc: don't warn about HEAD requests

Browse source 
Fixes #5451

R=gri
CC=dsymonds, gobot, golang-dev
https://golang.org/cl/9388043
This commit is contained in:
Brad Fitzpatrick 2013-05-14 21:21:11 -07:00
parent 2eeab323ad
commit d9d8d4c62c
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/cmd/godoc/godoc.go
View file

@ -642,7 +642,9 @@ func servePage(w http.ResponseWriter, page Page) {
page.SearchBox = *indexEnabled
page.Playground = *showPlayground
page.Version = runtime.Version()
if err := godocHTML.Execute(w, page); err != nil {
if err := godocHTML.Execute(w, page); err != nil && err != http.ErrBodyNotAllowed {
// Only log if there's an error that's not about writing on HEAD requests.
// See Issues 5451 and 5454.
log.Printf("godocHTML.Execute: %s", err)
}
}
@ -860,7 +862,9 @@ func serveSearchDesc(w http.ResponseWriter, r *http.Request) {
data := map[string]interface{}{
"BaseURL": fmt.Sprintf("http://%s", r.Host),
}
if err := searchDescXML.Execute(w, &data); err != nil {
if err := searchDescXML.Execute(w, &data); err != nil && err != http.ErrBodyNotAllowed {
// Only log if there's an error that's not about writing on HEAD requests.
// See Issues 5451 and 5454.
log.Printf("searchDescXML.Execute: %s", err)
}
}